makefs: use `char ` not `void ` for buf b_data and drop casts from msdos
ClosedPublic
Actions

Authored by emaste on Aug 20 2019, 9:57 PM.

Tags

None

Referenced Files

	F137433069: D21348.id61067.diff
	Sun, Nov 23, 10:15 AM

	Unknown Object (File)
	Thu, Nov 20, 2:47 PM

	Unknown Object (File)
	Thu, Nov 20, 2:29 PM

	Unknown Object (File)
	Thu, Nov 20, 2:28 PM

	Unknown Object (File)
	Thu, Nov 20, 2:27 PM

	Unknown Object (File)
	Thu, Nov 20, 2:25 PM

	Unknown Object (File)
	Thu, Nov 20, 2:25 PM

	Unknown Object (File)
	Thu, Nov 20, 2:16 PM

View All 97 Files

Subscribers

imp

Details

Reviewers

cem

Commits

rS351319: makefs: use `char *` not `void *` for buf b_data, drop casts in msdos

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Aug 20 2019, 9:57 PM

You've build-checked this, right? makefs/ffs has some casts of b_data to larger structure types, which are totally valid for void* but compilers may warn about casting from a lower-alignment type like char to a larger alignment type.

This revision is now accepted and ready to land.Aug 20 2019, 10:03 PM

You've build-checked this, right?

Yes on amd64.

Closed by commit rS351319: makefs: use `char *` not `void *` for buf b_data, drop casts in msdos (authored by emaste). · Explain WhyAug 21 2019, 1:46 AM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS351319: makefs: use `char *` not `void *` for buf b_data, drop casts in msdos.

Herald added a subscriber: imp. · View Herald TranscriptAug 21 2019, 1:46 AM

Revision Contents
Changeset List

Path

Size

ffs/

buf.h

2 lines

msdos/

msdosfs_fat.c

44 lines

Diff 61067

View Options

ffs/buf.h