ping: Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC)
ClosedPublic
Actions

Authored by jansucan on Aug 13 2019, 8:49 AM.

Details

Reviewers

asomers

Commits

rS350998: ping: use the monotonic clock to measure durations

Summary

Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC)

Submitted by: Ján Sučan <sucanjan@gmail.com>
Sponsored by: Google, inc. (Google Summer of Code 2019)

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25845
Build 24416: arc lint + arc unit

Event Timeline

jansucan created this revision.Aug 13 2019, 8:49 AM

Harbormaster completed remote builds in B25829: Diff 60717.Aug 13 2019, 8:49 AM

asomers requested changes to this revision.Aug 13 2019, 3:07 PM

asomers added inline comments.

sbin/ping/ping.c
894–895	These 10 lines can be replaced by `timespecadd`

This revision now requires changes to proceed.Aug 13 2019, 3:07 PM

Use timespecadd(), and timespecsub().

Harbormaster completed remote builds in B25845: Diff 60745.Aug 13 2019, 5:28 PM

jansucan added inline comments.Aug 13 2019, 5:28 PM

sbin/ping/ping.c
894–895	Fixed.

asomers accepted this revision.Aug 13 2019, 7:24 PM

This revision is now accepted and ready to land.Aug 13 2019, 7:24 PM

Closed by commit rS350998: ping: use the monotonic clock to measure durations (authored by asomers). · Explain WhyAug 13 2019, 7:27 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rS350998: ping: use the monotonic clock to measure durations.

Herald added a subscriber: imp. · View Herald TranscriptAug 13 2019, 7:27 PM

asomers mentioned this in rS352357: MFC r350994, r350998, r351030, r351033, r351171, r351223, r351226, r351424.Sep 15 2019, 4:53 PM

Revision Contents
Changeset List

Path

Size

sbin/

ping/

ping.c

91 lines

Diff 60745

View Options

ping: Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC)ClosedPublicActions