Add port for XKCDPass, a password generator modelled after XKCD #936
Details
Details
- Reviewers
0mp - Group Reviewers
Contributor Reviewers (ports) - Commits
- rP540701: New port: security/py-xkcdpass
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Modified security/Makefile to include the new port before py-xmlsec.
Previously the new port was not added in alphabetical order.
Comment Actions
Thanks for submission. There are a couple of issues with the current patch, however.
| security/py-xkcdpass/Makefile | ||
|---|---|---|
| 11 | It would be nice to set LICENSE_FILE | |
| 17 | This is the default. | |
| 18 | We could use ${DISTVERSION} here. | |
| 20 | Is this necessary? | |
| security/py-xkcdpass/pkg-descr | ||
| 4 | Missing WWW. | |
| security/py-xkcdpass/pkg-plist | ||
| 22 | This is invalid. Use make makeplist to generate it properly. | |
| security/py-xkcdpass/Makefile | ||
|---|---|---|
| 13 | Also, upstream README suggests that Python 2.7 and 3.4<= are supported. | |
Comment Actions
Fixed requested changes from 0mp.
Also, since creating the revision a new release (1.17.3.1 -> 1.17.4) is available
so this has also been reflected in the diff.
Note: Setting USES=python:2.7+ will allow building with Python 2.7, 3.5, 3.6, 3.7,
and 3.8, though Python 3.4 is also supported by upstream.
| security/py-xkcdpass/Makefile | ||
|---|---|---|
| 15 | python:2.7+ is unnecessary. Just python means the same thing. Remove tar. It is useless for this port since USE_GITHUB does not use EXTRACT_SUFX. | |
| 16 | It seems wrong to have a pkg-plist and USE_PYTHON=autoplist. You probably have duplicate plist entries and make check-plist will complain about with a weird error. | |
| 19 | Remove and set DISTVERSIONPREFIX=${PORTNAME}- instead. | |
| security/py-xkcdpass/pkg-descr | ||
| 2 | I think this description could be improved a lot by explaining XKCD 936 a little. | |
Comment Actions
Updated the port to include the changes requested by tobik.
I also added the DOCS option to allow installing the package's
README file to ${DOCSDIR} as this provides a little more usage
information to the user.
Comment Actions
Created a new diff from master to show all changes for the new port rather than just changes made since the last diff was uploaded to Phabricator.
I am new to Phabricator so please advise if this was necessary. I didn't realize the previous diff did not show all of the changes when I attached it to the revision.
Comment Actions
Committed with very minor changes. Nice work! Thanks for your patience and patches! Looking forward to future contributions! ;)