Paths

Table of Contentst

Differential D20802

porters handbook: Document qt-dist
ClosedPublic
Actions

Authored by tcberner on Jun 29 2019, 8:41 AM.

Tags

None

Referenced Files

	F169296594: D20802.id59203.diff
	Tue, Sep 1, 3:48 AM

	F169294936: D20802.id59278.diff
	Tue, Sep 1, 3:44 AM

	F169294856: D20802.id59186.diff
	Tue, Sep 1, 3:44 AM

	F169253002: D20802.id.diff
	Tue, Sep 1, 1:47 AM

	Unknown Object (File)
	Mon, Aug 31, 4:03 AM

	Unknown Object (File)
	Mon, Aug 31, 3:01 AM

	Unknown Object (File)
	Sun, Aug 30, 9:45 AM

	Unknown Object (File)
	Sat, Aug 29, 8:38 PM

Subscribers

None

Details

Reviewers

Group Reviewers

portmgr
kde

Commits

rD53207: Document qt-dist

Summary

Document usage of USES=qt-dist.

Diff Detail

Repository

rD FreeBSD doc repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tcberner created this revision.Jun 29 2019, 8:41 AM

tcberner added reviewers: mat, portmgr, kde.

tcberner added inline comments.Jun 29 2019, 8:44 AM

special/chapter.xml
2905 ↗	(On Diff #59186)	^ `vim`

I don't think the <sect2> are needed, the section is not long, and having examples in a separate subsection does not make a lot of sense (to me at least).

Do you mind if I work on the formatting/presentation? It will probably go faster than going back and forth with all the small remarks I'll think of.

In D20802#450348, @mat wrote:

I don't think the <sect2> are needed, the section is not long, and having examples in a separate subsection does not make a lot of sense (to me at least).

Do you mind if I work on the formatting/presentation? It will probably go faster than going back and forth with all the small remarks I'll think of.

Sure, go ahead.

Rework.

Herald added 1 blocking reviewer(s): mat. · View Herald TranscriptJun 29 2019, 3:39 PM

Harbormaster completed remote builds in B25122: Diff 59197.Jun 29 2019, 3:40 PM

Add a note in the Qt chapter.

Harbormaster completed remote builds in B25123: Diff 59198.Jun 29 2019, 3:58 PM

tcberner added inline comments.Jun 29 2019, 4:14 PM

en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
2797 ↗	(On Diff #59198)	^ it should probably be `distfile` not `component name` as I would say `gui` is the component and `base` the dist.

feedback.

Harbormaster completed remote builds in B25124: Diff 59203.Jun 29 2019, 5:54 PM

linimon retitled this revision from Document qt-dist to porters handbook: Document qt-dist.Jun 30 2019, 3:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 1 2019, 7:22 PM

Closed by commit rD53207: Document qt-dist (authored by mat). · Explain Why

This revision was automatically updated to reflect the committed changes.

mat added a commit: rD53207: Document qt-dist.

Thanks.

Revision Contents
Changeset List

Path

Size

head/

en_US.ISO8859-1/

books/

porters-handbook/

special/

5 lines

uses/

63 lines

Diff 59278

head/en_US.ISO8859-1/books/porters-handbook/special/chapter.xml

Loading...

head/en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml

Loading...