Page MenuHomeFreeBSD
Differential D20802

porters handbook: Document qt-dist
ClosedPublic
Actions

Authored by tcberner on Jun 29 2019, 8:41 AM.
Tags
None
Referenced Files
F83054413: D20802.diff
Sun, May 5, 4:03 PM
Unknown Object (File)
Thu, May 2, 8:41 PM
Unknown Object (File)
Thu, May 2, 7:42 PM
Unknown Object (File)
Thu, May 2, 7:25 PM
Unknown Object (File)
Thu, May 2, 7:18 PM
Unknown Object (File)
Thu, May 2, 7:18 PM
Unknown Object (File)
Thu, May 2, 7:18 PM
Unknown Object (File)
Thu, May 2, 7:18 PM
View All 40 Files
Subscribers
None

Details

Reviewers
mat
Group Reviewers
portmgr
kde
Commits
rD53207: Document qt-dist
Summary

Document usage of USES=qt-dist.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 25122
Build 23820: arc lint + arc unit

Event Timeline

tcberner created this revision.Jun 29 2019, 8:41 AM
tcberner added reviewers: mat, portmgr, kde.
tcberner added inline comments.Jun 29 2019, 8:44 AM
special/chapter.xml
2905 ↗(On Diff #59186)

^ vim

mat added a comment.Jun 29 2019, 1:00 PM

I don't think the <sect2> are needed, the section is not long, and having examples in a separate subsection does not make a lot of sense (to me at least).

Do you mind if I work on the formatting/presentation? It will probably go faster than going back and forth with all the small remarks I'll think of.

tcberner added a comment.Jun 29 2019, 1:44 PM
In D20802#450348, @mat wrote:

I don't think the <sect2> are needed, the section is not long, and having examples in a separate subsection does not make a lot of sense (to me at least).

Do you mind if I work on the formatting/presentation? It will probably go faster than going back and forth with all the small remarks I'll think of.

Sure, go ahead.

mat updated this revision to Diff 59197.Jun 29 2019, 3:39 PM
  • Rework.
Herald added 1 blocking reviewer(s): mat. · View Herald TranscriptJun 29 2019, 3:39 PM
Harbormaster completed remote builds in B25122: Diff 59197.Jun 29 2019, 3:40 PM
mat updated this revision to Diff 59198.Jun 29 2019, 3:58 PM
  • Add a note in the Qt chapter.
Harbormaster completed remote builds in B25123: Diff 59198.Jun 29 2019, 3:58 PM
tcberner added inline comments.Jun 29 2019, 4:14 PM
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
2797

^ it should probably be distfile not component name as I would say gui is the component and base the dist.

mat updated this revision to Diff 59203.Jun 29 2019, 5:54 PM
  • feedback.
Harbormaster completed remote builds in B25124: Diff 59203.Jun 29 2019, 5:54 PM
linimon retitled this revision from Document qt-dist to porters handbook: Document qt-dist.Jun 30 2019, 3:58 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 1 2019, 7:22 PM
Closed by commit rD53207: Document qt-dist (authored by mat). · Explain Why
This revision was automatically updated to reflect the committed changes.
mat added a commit: rD53207: Document qt-dist.
tcberner added a comment.Jul 1 2019, 8:55 PM

Thanks.

Revision Contents
Changeset List

PathSize
en_US.ISO8859-1/
books/
porters-handbook/
uses/
63 lines

Diff 59197

View Options

en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml

Loading...