Page MenuHomeFreeBSD

Cleanup patching of static content with sed.
ClosedPublic

Authored by mat on Jun 17 2019, 8:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 4:44 AM
Unknown Object (File)
Nov 7 2023, 12:04 PM
Unknown Object (File)
Nov 7 2023, 2:29 AM
Unknown Object (File)
Nov 6 2023, 6:17 PM
Unknown Object (File)
Oct 6 2023, 10:59 AM
Unknown Object (File)
Oct 6 2023, 1:23 AM
Unknown Object (File)
Oct 5 2023, 5:15 PM
Unknown Object (File)
Sep 14 2023, 9:00 PM
Subscribers

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24958
Build 23679: arc lint + arc unit

Event Timeline

adamw added inline comments.
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
7600

This version has ${PREFIX}, but the one above has ${LOCALBASE}.

en_US.ISO8859-1/books/porters-handbook/slow-porting/chapter.xml
422

This should be a semicolon, not a comma.

mat marked an inline comment as done.Jun 20 2019, 10:56 AM
mat added inline comments.
en_US.ISO8859-1/books/porters-handbook/slow-porting/chapter.xml
422

This seems off:

Do not use it to replace static content; use patch files for that.

For me, semicolon is used to separate two non related clauses, which could be separate sentences. Here, the two clauses are related and the second emphasizes the first.

en_US.ISO8859-1/books/porters-handbook/slow-porting/chapter.xml
422

The problem is that with a comma, one of the clauses must be dependent (i.e. a non-complete sentence). Here, both clauses are complete sentences, making it what's called a "comma splice."

I fully agree that the semicolon is weird there. Perhaps "You must use patch files instead of sed to replace static content." Or something like that.

mat marked 2 inline comments as done.Jun 20 2019, 2:36 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 20 2019, 2:36 PM
This revision was automatically updated to reflect the committed changes.