www/rubygem-rest-client: update to 1.8.0
ClosedPublic
Actions

Authored by mmoll on May 31 2015, 5:49 PM.

Details

Reviewers

swills
mat

Summary

This is PR 200504. Proposed commit message:

www/rubygem-rest-client: update to 1.8.0

PR:             200504
Submitted by:   Sevan Janiyan <venture37@geeklan.co.uk>
Approved by:    swills (mentor), mat (mentor)
Security:       CVE-2015-1820
Security:       CVE-2015-3448

Test Plan

http://space.kvedulv.de/FreeBSD/rubygem-rest-client_1/build.html

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

mmoll updated this revision to Diff 5842.May 31 2015, 5:49 PM

mmoll retitled this revision from to www/rubygem-rest-client: update to 1.8.0.

mmoll updated this object.

mmoll edited the test plan for this revision. (Show Details)

This looks good, thanks for looking at it. For apipie-bindings, hopefully it doesn't really need < 1.8. If so, we'll have to re-add 1.6 with a patch. How much was it tested?

This revision is now accepted and ready to land.May 31 2015, 7:16 PM

In D2696#50915, @swills wrote:

For apipie-bindings, hopefully it doesn't really need < 1.8. If so, we'll have to re-add 1.6 with a patch. How much was it tested?

I tested lightly with hammer, which inturn also uses apipie and surprislingly it just works. The only thing I noted was that the CA certificate of the API endpoint must now be in the system's CAs, which is for sure something users might note as problem after this update.

One question: is this OK to commit everything at once or first www/rubygem-rest-client and then the others?

mmoll updated this object.May 31 2015, 7:43 PM

mmoll added a reviewer: mat.

Sounds good, thanks for testing. Probably OK to commit it all together, IMHO.

committed in rP388165

Revision Contents
Changeset List

Path

Size

databases/

rubygem-couchrest/

Makefile

1 line

files

patch-couchrest.gemspec

11 lines

devel/

rubygem-apipie-bindings/

Makefile

1 line

files

patch-apipie-bindings.gemspec

11 lines

sysutils/

rubygem-chef/

Makefile

2 lines

files/

	patch-chef.gemspec
	patch-gemspec

10 lines

patch-gemspec

rubygem-hammer_cli/

Makefile

4 lines

files/

patch-gemspec

	patch-hammer__cli.gemspec
	patch-gemspec

9 lines

rubygem-hammer_cli_foreman/

Makefile

1 line

files

patch-hammer__cli__foreman.gemspec

11 lines

www/

rubygem-heroku/

Makefile

1 line

files

patch-heroku.gemspec

11 lines

rubygem-kensa/

Makefile

1 line

files

patch-kensa.gemspec

11 lines

rubygem-rest-client/

Makefile

6 lines

distinfo

4 lines

Diff 5842

View Options

databases/rubygem-couchrest/Makefile

Show First 20 Lines • Show All 309 Lines • ▼ Show 20 Lines	pmcstat_image_get_elf_params(struct pmcstat_image *image,
uintfptr_t minva, maxva;		uintfptr_t minva, maxva;
Elf *e;		Elf *e;
Elf_Scn *scn;		Elf_Scn *scn;
GElf_Ehdr eh;		GElf_Ehdr eh;
GElf_Phdr ph;		GElf_Phdr ph;
GElf_Shdr sh;		GElf_Shdr sh;
enum pmcstat_image_type image_type;		enum pmcstat_image_type image_type;
char buffer[PATH_MAX];		char buffer[PATH_MAX];
char buffer_modules[PATH_MAX];

assert(image->pi_type == PMCSTAT_IMAGE_UNKNOWN);		assert(image->pi_type == PMCSTAT_IMAGE_UNKNOWN);

image->pi_start = minva = ~(uintfptr_t) 0;		image->pi_start = minva = ~(uintfptr_t) 0;
image->pi_end = maxva = (uintfptr_t) 0;		image->pi_end = maxva = (uintfptr_t) 0;
image->pi_type = image_type = PMCSTAT_IMAGE_INDETERMINABLE;		image->pi_type = image_type = PMCSTAT_IMAGE_INDETERMINABLE;
image->pi_isdynamic = 0;		image->pi_isdynamic = 0;
image->pi_dynlinkerpath = NULL;		image->pi_dynlinkerpath = NULL;
image->pi_vaddr = 0;		image->pi_vaddr = 0;

path = pmcstat_string_unintern(image->pi_execpath);		path = pmcstat_string_unintern(image->pi_execpath);
assert(path != NULL);		assert(path != NULL);

/*		/*
* Look for kernel modules under FSROOT/KERNELPATH/NAME and		* Look for files under FSROOT/PATHNAME.
* FSROOT/boot/modules/NAME, and user mode executable objects
* under FSROOT/PATHNAME.
*/		*/
if (image->pi_iskernelmodule) {
(void) snprintf(buffer, sizeof(buffer), "%s%s/%s",
args->pa_fsroot, args->pa_kernel, path);
(void) snprintf(buffer_modules, sizeof(buffer_modules),
"%s/boot/modules/%s", args->pa_fsroot, path);
} else {
(void) snprintf(buffer, sizeof(buffer), "%s%s",		(void) snprintf(buffer, sizeof(buffer), "%s%s",
args->pa_fsroot, path);		args->pa_fsroot, path);
}

e = NULL;		e = NULL;
fd = open(buffer, O_RDONLY, 0);		fd = open(buffer, O_RDONLY, 0);
if (fd < 0 && !image->pi_iskernelmodule) {		if (fd < 0) {
warnx("WARNING: Cannot open \"%s\".",		warnx("WARNING: Cannot open \"%s\".",
buffer);		buffer);
goto done;		goto done;
}		}
if (fd < 0 && (fd = open(buffer_modules, O_RDONLY, 0)) < 0) {
warnx("WARNING: Cannot open \"%s\" or \"%s\".",
buffer, buffer_modules);
goto done;
}
if (elf_version(EV_CURRENT) == EV_NONE) {		if (elf_version(EV_CURRENT) == EV_NONE) {
warnx("WARNING: failed to init elf\n");		warnx("WARNING: failed to init elf\n");
goto done;		goto done;
}		}

if ((e = elf_begin(fd, ELF_C_READ, NULL)) == NULL) {		if ((e = elf_begin(fd, ELF_C_READ, NULL)) == NULL) {
warnx("WARNING: Cannot read \"%s\".",		warnx("WARNING: Cannot read \"%s\".",
buffer);		buffer);
▲ Show 20 Lines • Show All 201 Lines • Show Last 20 Lines

View Options

databases/rubygem-couchrest/files/

Show First 20 Lines • Show All 309 Lines • ▼ Show 20 Lines	pmcstat_image_get_elf_params(struct pmcstat_image *image,
uintfptr_t minva, maxva;		uintfptr_t minva, maxva;
Elf *e;		Elf *e;
Elf_Scn *scn;		Elf_Scn *scn;
GElf_Ehdr eh;		GElf_Ehdr eh;
GElf_Phdr ph;		GElf_Phdr ph;
GElf_Shdr sh;		GElf_Shdr sh;
enum pmcstat_image_type image_type;		enum pmcstat_image_type image_type;
char buffer[PATH_MAX];		char buffer[PATH_MAX];
char buffer_modules[PATH_MAX];

assert(image->pi_type == PMCSTAT_IMAGE_UNKNOWN);		assert(image->pi_type == PMCSTAT_IMAGE_UNKNOWN);

image->pi_start = minva = ~(uintfptr_t) 0;		image->pi_start = minva = ~(uintfptr_t) 0;
image->pi_end = maxva = (uintfptr_t) 0;		image->pi_end = maxva = (uintfptr_t) 0;
image->pi_type = image_type = PMCSTAT_IMAGE_INDETERMINABLE;		image->pi_type = image_type = PMCSTAT_IMAGE_INDETERMINABLE;
image->pi_isdynamic = 0;		image->pi_isdynamic = 0;
image->pi_dynlinkerpath = NULL;		image->pi_dynlinkerpath = NULL;
image->pi_vaddr = 0;		image->pi_vaddr = 0;

path = pmcstat_string_unintern(image->pi_execpath);		path = pmcstat_string_unintern(image->pi_execpath);
assert(path != NULL);		assert(path != NULL);

/*		/*
* Look for kernel modules under FSROOT/KERNELPATH/NAME and		* Look for files under FSROOT/PATHNAME.
* FSROOT/boot/modules/NAME, and user mode executable objects
* under FSROOT/PATHNAME.
*/		*/
if (image->pi_iskernelmodule) {
(void) snprintf(buffer, sizeof(buffer), "%s%s/%s",
args->pa_fsroot, args->pa_kernel, path);
(void) snprintf(buffer_modules, sizeof(buffer_modules),
"%s/boot/modules/%s", args->pa_fsroot, path);
} else {
(void) snprintf(buffer, sizeof(buffer), "%s%s",		(void) snprintf(buffer, sizeof(buffer), "%s%s",
args->pa_fsroot, path);		args->pa_fsroot, path);
}

e = NULL;		e = NULL;
fd = open(buffer, O_RDONLY, 0);		fd = open(buffer, O_RDONLY, 0);
if (fd < 0 && !image->pi_iskernelmodule) {		if (fd < 0) {
warnx("WARNING: Cannot open \"%s\".",		warnx("WARNING: Cannot open \"%s\".",
buffer);		buffer);
goto done;		goto done;
}		}
if (fd < 0 && (fd = open(buffer_modules, O_RDONLY, 0)) < 0) {
warnx("WARNING: Cannot open \"%s\" or \"%s\".",
buffer, buffer_modules);
goto done;
}
if (elf_version(EV_CURRENT) == EV_NONE) {		if (elf_version(EV_CURRENT) == EV_NONE) {
warnx("WARNING: failed to init elf\n");		warnx("WARNING: failed to init elf\n");
goto done;		goto done;
}		}

if ((e = elf_begin(fd, ELF_C_READ, NULL)) == NULL) {		if ((e = elf_begin(fd, ELF_C_READ, NULL)) == NULL) {
warnx("WARNING: Cannot read \"%s\".",		warnx("WARNING: Cannot read \"%s\".",
buffer);		buffer);
▲ Show 20 Lines • Show All 201 Lines • Show Last 20 Lines

View Options

databases/rubygem-couchrest/files/patch-couchrest.gemspec

Show First 20 Lines • Show All 309 Lines • ▼ Show 20 Lines	pmcstat_image_get_elf_params(struct pmcstat_image *image,
uintfptr_t minva, maxva;		uintfptr_t minva, maxva;
Elf *e;		Elf *e;
Elf_Scn *scn;		Elf_Scn *scn;
GElf_Ehdr eh;		GElf_Ehdr eh;
GElf_Phdr ph;		GElf_Phdr ph;
GElf_Shdr sh;		GElf_Shdr sh;
enum pmcstat_image_type image_type;		enum pmcstat_image_type image_type;
char buffer[PATH_MAX];		char buffer[PATH_MAX];
char buffer_modules[PATH_MAX];

assert(image->pi_type == PMCSTAT_IMAGE_UNKNOWN);		assert(image->pi_type == PMCSTAT_IMAGE_UNKNOWN);

image->pi_start = minva = ~(uintfptr_t) 0;		image->pi_start = minva = ~(uintfptr_t) 0;
image->pi_end = maxva = (uintfptr_t) 0;		image->pi_end = maxva = (uintfptr_t) 0;
image->pi_type = image_type = PMCSTAT_IMAGE_INDETERMINABLE;		image->pi_type = image_type = PMCSTAT_IMAGE_INDETERMINABLE;
image->pi_isdynamic = 0;		image->pi_isdynamic = 0;
image->pi_dynlinkerpath = NULL;		image->pi_dynlinkerpath = NULL;
image->pi_vaddr = 0;		image->pi_vaddr = 0;

path = pmcstat_string_unintern(image->pi_execpath);		path = pmcstat_string_unintern(image->pi_execpath);
assert(path != NULL);		assert(path != NULL);

/*		/*
* Look for kernel modules under FSROOT/KERNELPATH/NAME and		* Look for files under FSROOT/PATHNAME.
* FSROOT/boot/modules/NAME, and user mode executable objects
* under FSROOT/PATHNAME.
*/		*/
if (image->pi_iskernelmodule) {
(void) snprintf(buffer, sizeof(buffer), "%s%s/%s",
args->pa_fsroot, args->pa_kernel, path);
(void) snprintf(buffer_modules, sizeof(buffer_modules),
"%s/boot/modules/%s", args->pa_fsroot, path);
} else {
(void) snprintf(buffer, sizeof(buffer), "%s%s",		(void) snprintf(buffer, sizeof(buffer), "%s%s",
args->pa_fsroot, path);		args->pa_fsroot, path);
}

e = NULL;		e = NULL;
fd = open(buffer, O_RDONLY, 0);		fd = open(buffer, O_RDONLY, 0);
if (fd < 0 && !image->pi_iskernelmodule) {		if (fd < 0) {
warnx("WARNING: Cannot open \"%s\".",		warnx("WARNING: Cannot open \"%s\".",
buffer);		buffer);
goto done;		goto done;
}		}
if (fd < 0 && (fd = open(buffer_modules, O_RDONLY, 0)) < 0) {
warnx("WARNING: Cannot open \"%s\" or \"%s\".",
buffer, buffer_modules);
goto done;
}
if (elf_version(EV_CURRENT) == EV_NONE) {		if (elf_version(EV_CURRENT) == EV_NONE) {
warnx("WARNING: failed to init elf\n");		warnx("WARNING: failed to init elf\n");
goto done;		goto done;
}		}

if ((e = elf_begin(fd, ELF_C_READ, NULL)) == NULL) {		if ((e = elf_begin(fd, ELF_C_READ, NULL)) == NULL) {
warnx("WARNING: Cannot read \"%s\".",		warnx("WARNING: Cannot read \"%s\".",
buffer);		buffer);
▲ Show 20 Lines • Show All 201 Lines • Show Last 20 Lines

View Options

devel/rubygem-apipie-bindings/Makefile

Show First 20 Lines • Show All 309 Lines • ▼ Show 20 Lines	pmcstat_image_get_elf_params(struct pmcstat_image *image,
uintfptr_t minva, maxva;		uintfptr_t minva, maxva;
Elf *e;		Elf *e;
Elf_Scn *scn;		Elf_Scn *scn;
GElf_Ehdr eh;		GElf_Ehdr eh;
GElf_Phdr ph;		GElf_Phdr ph;
GElf_Shdr sh;		GElf_Shdr sh;
enum pmcstat_image_type image_type;		enum pmcstat_image_type image_type;
char buffer[PATH_MAX];		char buffer[PATH_MAX];
char buffer_modules[PATH_MAX];

assert(image->pi_type == PMCSTAT_IMAGE_UNKNOWN);		assert(image->pi_type == PMCSTAT_IMAGE_UNKNOWN);

image->pi_start = minva = ~(uintfptr_t) 0;		image->pi_start = minva = ~(uintfptr_t) 0;
image->pi_end = maxva = (uintfptr_t) 0;		image->pi_end = maxva = (uintfptr_t) 0;
image->pi_type = image_type = PMCSTAT_IMAGE_INDETERMINABLE;		image->pi_type = image_type = PMCSTAT_IMAGE_INDETERMINABLE;
image->pi_isdynamic = 0;		image->pi_isdynamic = 0;
image->pi_dynlinkerpath = NULL;		image->pi_dynlinkerpath = NULL;
image->pi_vaddr = 0;		image->pi_vaddr = 0;

path = pmcstat_string_unintern(image->pi_execpath);		path = pmcstat_string_unintern(image->pi_execpath);
assert(path != NULL);		assert(path != NULL);

/*		/*
* Look for kernel modules under FSROOT/KERNELPATH/NAME and		* Look for files under FSROOT/PATHNAME.
* FSROOT/boot/modules/NAME, and user mode executable objects
* under FSROOT/PATHNAME.
*/		*/
if (image->pi_iskernelmodule) {
(void) snprintf(buffer, sizeof(buffer), "%s%s/%s",
args->pa_fsroot, args->pa_kernel, path);
(void) snprintf(buffer_modules, sizeof(buffer_modules),
"%s/boot/modules/%s", args->pa_fsroot, path);
} else {
(void) snprintf(buffer, sizeof(buffer), "%s%s",		(void) snprintf(buffer, sizeof(buffer), "%s%s",
args->pa_fsroot, path);		args->pa_fsroot, path);
}

e = NULL;		e = NULL;
fd = open(buffer, O_RDONLY, 0);		fd = open(buffer, O_RDONLY, 0);
if (fd < 0 && !image->pi_iskernelmodule) {		if (fd < 0) {
warnx("WARNING: Cannot open \"%s\".",		warnx("WARNING: Cannot open \"%s\".",
buffer);		buffer);
goto done;		goto done;
}		}
if (fd < 0 && (fd = open(buffer_modules, O_RDONLY, 0)) < 0) {
warnx("WARNING: Cannot open \"%s\" or \"%s\".",
buffer, buffer_modules);
goto done;
}
if (elf_version(EV_CURRENT) == EV_NONE) {		if (elf_version(EV_CURRENT) == EV_NONE) {
warnx("WARNING: failed to init elf\n");		warnx("WARNING: failed to init elf\n");
goto done;		goto done;
}		}

if ((e = elf_begin(fd, ELF_C_READ, NULL)) == NULL) {		if ((e = elf_begin(fd, ELF_C_READ, NULL)) == NULL) {
warnx("WARNING: Cannot read \"%s\".",		warnx("WARNING: Cannot read \"%s\".",
buffer);		buffer);
▲ Show 20 Lines • Show All 201 Lines • Show Last 20 Lines