Page MenuHomeFreeBSD

www/rubygem-rest-client: update to 1.8.0
ClosedPublic

Authored by mmoll on May 31 2015, 5:49 PM.

Details

Reviewers
swills
mat
Summary

This is PR 200504. Proposed commit message:

www/rubygem-rest-client: update to 1.8.0

PR:             200504
Submitted by:   Sevan Janiyan <venture37@geeklan.co.uk>
Approved by:    swills (mentor), mat (mentor)
Security:       CVE-2015-1820
Security:       CVE-2015-3448
Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mmoll updated this revision to Diff 5842.May 31 2015, 5:49 PM
mmoll retitled this revision from to www/rubygem-rest-client: update to 1.8.0.
mmoll updated this object.
mmoll edited the test plan for this revision. (Show Details)
swills accepted this revision.May 31 2015, 7:16 PM
swills added a reviewer: swills.
swills added a subscriber: swills.

This looks good, thanks for looking at it. For apipie-bindings, hopefully it doesn't really need < 1.8. If so, we'll have to re-add 1.6 with a patch. How much was it tested?

This revision is now accepted and ready to land.May 31 2015, 7:16 PM
mmoll added a comment.May 31 2015, 7:35 PM
In D2696#50915, @swills wrote:

For apipie-bindings, hopefully it doesn't really need < 1.8. If so, we'll have to re-add 1.6 with a patch. How much was it tested?

I tested lightly with hammer, which inturn also uses apipie and surprislingly it just works. The only thing I noted was that the CA certificate of the API endpoint must now be in the system's CAs, which is for sure something users might note as problem after this update.

mmoll added a comment.May 31 2015, 7:36 PM

One question: is this OK to commit everything at once or first www/rubygem-rest-client and then the others?

mmoll updated this object.May 31 2015, 7:43 PM
mmoll added a reviewer: mat.

Sounds good, thanks for testing. Probably OK to commit it all together, IMHO.

mmoll closed this revision.May 31 2015, 8:59 PM

committed in rP388165