Page MenuHomeFreeBSD

Remove "struct ucred*" argument from vtruncbuf
ClosedPublic

Authored by asomers on May 23 2019, 2:03 PM.
Tags
None
Referenced Files
F157461318: D20377.diff
Thu, May 21, 5:28 PM
F157461311: D20377.diff
Thu, May 21, 5:28 PM
Unknown Object (File)
Sun, May 10, 6:46 PM
Unknown Object (File)
Sun, May 10, 8:45 AM
Unknown Object (File)
Sun, May 10, 6:07 AM
Unknown Object (File)
Sat, May 9, 5:12 PM
Unknown Object (File)
Sat, May 9, 9:13 AM
Unknown Object (File)
Fri, May 8, 6:52 PM
Subscribers

Details

Summary

Remove "struct ucred*" argument from vtruncbuf

vtruncbuf takes a "struct ucred*" argument. AFAICT, it's been unused ever
since that function was first added in r34611. Remove it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24426
Build 23239: arc lint + arc unit

Event Timeline

LGTM, thanks!

sys/fs/fuse/fuse_io.c
392

I'd structure this as two separate commits, vtruncbuf first, fuse second; or at least update the commit message to reflect that FUSE was also changed in a similar fashion.

466

Might as well fix the line wrapping whitespace while you're here? Not a big deal. Ditto below.

sys/fs/nfsclient/nfs_clbio.c
1835

Ditto the comment in FUSE: I'd structure this as another independent commit, but if not, please mention it in the commit message as well.

This revision is now accepted and ready to land.May 23 2019, 4:24 PM
sys/fs/nfsclient/nfs_clbio.c
1835

Ok, I'll mention it in the commit message. I don't want to separate it into two commits, because that would create more unused arguments in ncl_meta_setsize and fuse_vnode_setsize.

sys/fs/nfsclient/nfs_clbio.c
1835

Briefly, yes, but then the followup commit(s) would remove those. Doing it all in one is totally reasonable, too.

This revision was automatically updated to reflect the committed changes.