Differential D20282
Fix nda(4) PCIe link status output Authored by chuck on May 17 2019, 12:45 AM. Tags None Referenced Files
Subscribers None
Details
Differentiate between PCI Express Endpoint devices and Root Complex Integrated Endpoints in the nda driver. The Link Status and Capability registers are not valid for Integrated Endpoints and should not be displayed. The bhyve emulated NVMe device will advertise as being an Integrated Endpoint. Note this fix is dependent on D19904
Diff Detail
Event TimelineComment Actions This looks good. The multiple printfs give me heart-burn, but that's for another day. This part of the code they should be safe, but they aren't safe in a future where we do device discovery in parallel. Comment Actions It would be easy to turn this into a series of snprintfs() and then a single printf(). Would that clear the heartburn? Comment Actions Yes, I think that would be better. The unfortunate thing is that multiple printfs often end up interleaved in the logs. A single printf should be done in one contiguous chunk. At some point we should also implement the announce_sbuf() transport function for NVMe. Comment Actions Convert to using sbuf to avoid log messages from being interleaved once the discovery is done in parallel |