Page MenuHomeFreeBSD
Differential D20285

textproc/topic: fix build with GCC-based architectures
ClosedPublic
Actions

Authored by pkubaj on May 17 2019, 10:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 8, 2:36 PM
Unknown Object (File)
Mon, Oct 6, 9:40 AM
Unknown Object (File)
Fri, Oct 3, 9:23 PM
Unknown Object (File)
Fri, Oct 3, 4:46 PM
Unknown Object (File)
Fri, Oct 3, 2:45 AM
Unknown Object (File)
Sep 27 2025, 6:28 PM
Unknown Object (File)
Sep 23 2025, 5:28 AM
Unknown Object (File)
Jul 29 2025, 2:05 AM
View All 71 Files
Subscribers
None

Details

Reviewers
linimon
mat
tcberner
Commits
rP502123: textproc/topic: fix build with GCC-based architectures
Summary

Remove -Werror to fix this:
./linenoise.c: In function 'linenoiseEdit':
./linenoise.c:765: warning: comparison is always false due to limited range of data type

With -Werror, it causes a build error on GCC architectures.

PR: 237555

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24290
Build 23116: arc lint + arc unit

Event Timeline

pkubaj created this revision.May 17 2019, 10:49 AM
Harbormaster completed remote builds in B24276: Diff 57476.May 17 2019, 10:49 AM
tcberner added a comment.May 17 2019, 6:57 PM

Not quite sure if that makes sense. Won't the compiled binary basically do garbage in this case?

pkubaj updated this revision to Diff 57500.May 17 2019, 7:50 PM

Add specific signed to the variable. This solves the build issue.

Harbormaster completed remote builds in B24290: Diff 57500.May 17 2019, 7:50 PM
mat accepted this revision.May 20 2019, 12:37 PM
This revision is now accepted and ready to land.May 20 2019, 12:37 PM
Closed by commit rP502123: textproc/topic: fix build with GCC-based architectures (authored by pkubaj). · Explain WhyMay 20 2019, 4:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
textproc/
topic/
2 lines
11 lines

Diff 57500

View Options

textproc/topic/Makefile

Loading...
View Options

textproc/topic/files/

Loading...
View Options

textproc/topic/files/patch-linenoise.c

Loading...