Page MenuHomeFreeBSD

textproc/topic: fix build with GCC-based architectures
ClosedPublic

Authored by pkubaj on May 17 2019, 10:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 28, 10:39 AM
Unknown Object (File)
Dec 31 2023, 12:31 AM
Unknown Object (File)
Dec 20 2023, 1:12 AM
Unknown Object (File)
Nov 5 2023, 7:34 PM
Unknown Object (File)
Jul 15 2023, 10:13 PM
Unknown Object (File)
Jun 26 2023, 11:11 PM
Unknown Object (File)
May 31 2023, 6:57 PM
Subscribers
None

Details

Summary

Remove -Werror to fix this:
./linenoise.c: In function 'linenoiseEdit':
./linenoise.c:765: warning: comparison is always false due to limited range of data type

With -Werror, it causes a build error on GCC architectures.

PR: 237555

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Not quite sure if that makes sense. Won't the compiled binary basically do garbage in this case?

Add specific signed to the variable. This solves the build issue.

This revision is now accepted and ready to land.May 20 2019, 12:37 PM
This revision was automatically updated to reflect the committed changes.