Page MenuHomeFreeBSD

devel/thrift-cpp: fix build with GCC-based architectures
ClosedPublic

Authored by pkubaj on May 17 2019, 10:54 AM.
Tags
None
Referenced Files
F166119768: D20287.id.diff
Tue, Aug 11, 9:26 PM
Unknown Object (File)
Tue, Aug 11, 10:30 AM
Unknown Object (File)
Tue, Aug 11, 3:14 AM
Unknown Object (File)
Mon, Aug 10, 3:36 AM
Unknown Object (File)
Sat, Aug 8, 3:48 PM
Unknown Object (File)
Sat, Aug 8, 8:18 AM
Unknown Object (File)
Sat, Aug 8, 12:00 AM
Unknown Object (File)
Thu, Aug 6, 10:35 PM
Subscribers
None

Details

Summary

Add -L${OPENSSLLIB} -I${OPENSSLINC} only when base OpenSSL isn't used. Explicitly adding -L/usr/lib make ports GCC link to libstdc++ from /usr/lib instead of /usr/local/lib/gcc8.

Also, explicitly don't use Lua and Qt5, the port uses it if it's installed.

PR: 237506

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24289
Build 23115: arc lint + arc unit

Event Timeline

devel/thrift-cpp/Makefile
47

^I'd say this warrants a PORTREVISON bump

Looks ok, pending maintainer's approval.

This revision is now accepted and ready to land.May 20 2019, 12:36 PM
This revision was automatically updated to reflect the committed changes.

Committed because maintainer timeout.