Page MenuHomeFreeBSD
Differential D20185

Mark __inline functions which are not neccessarily used, with __unused.
ClosedPublic
Actions

Authored by trasz on May 7 2019, 5:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 21, 1:21 AM
Unknown Object (File)
Sat, Nov 15, 7:57 AM
Unknown Object (File)
Mon, Nov 10, 5:21 PM
Unknown Object (File)
Mon, Nov 10, 1:42 PM
Unknown Object (File)
Mon, Nov 10, 1:42 PM
Unknown Object (File)
Mon, Nov 10, 1:35 PM
Unknown Object (File)
Mon, Nov 10, 10:22 AM
Unknown Object (File)
Mon, Nov 10, 8:13 AM
View All 89 Files
Subscribers
imp

Details

Reviewers
kib
Commits
rS347360: Mark inline functions with __unused; prevents compiler warning
Summary

Mark inline functions with unused; prevents compiler warning when they end up being unused.

Obtained from: OpenBSD

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz created this revision.May 7 2019, 5:53 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 7 2019, 5:53 PM
Harbormaster completed remote builds in B24136: Diff 57140.May 7 2019, 5:53 PM
kib added a comment.May 7 2019, 6:12 PM

It is very strange selection of functions. Why that set and not another ?

Either we mark some functions as __unused when we get specific warnings, or we mark everything. Look for instance at r321512.

trasz added a comment.May 7 2019, 7:04 PM

Not sure what do you mean. I think I've marked all __inline functions there?

kib added a comment.May 8 2019, 9:08 AM
In D20185#434944, @trasz wrote:

Not sure what do you mean. I think I've marked all __inline functions there?

Well, the commit message should be very different then. 'Which are not neccessary used' does not imply 'all inlines (or static)', and of course I did not even look into 1KLoC file to confirm that.

trasz edited the summary of this revision. (Show Details)May 8 2019, 3:43 PM

That was copy/paste from OpenBSD's commit message, but okay. How about now?

kib accepted this revision.May 8 2019, 4:13 PM
This revision is now accepted and ready to land.May 8 2019, 4:13 PM
Closed by commit rS347360: Mark inline functions with __unused; prevents compiler warning (authored by trasz). · Explain WhyMay 8 2019, 6:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
sys/
6 lines

Diff 57192

View Options

head/sys/sys/tree.h

Loading...