Page MenuHomeFreeBSD
Differential D20186

Add simple regression tests for tree(3).
ClosedPublic
Actions

Authored by trasz on May 7 2019, 5:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 20, 10:08 PM
Unknown Object (File)
Wed, Jun 19, 10:35 AM
Unknown Object (File)
May 10 2024, 5:38 PM
Unknown Object (File)
May 4 2024, 8:00 PM
Unknown Object (File)
May 2 2024, 8:18 PM
Unknown Object (File)
May 2 2024, 8:17 PM
Unknown Object (File)
May 2 2024, 4:14 PM
Unknown Object (File)
May 2 2024, 11:43 AM
View All 34 Files
Subscribers
imp

Details

Reviewers
ngie
Commits
rS347425: Add simple regression tests for tree(3). Those are ATF-ified versions
Summary

Add simple regression tests for tree(3). Those are ATF-ified versions
of OpenBSD's regress/sys/sys/tree/.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24137
Build 22990: arc lint + arc unit

Event Timeline

trasz created this revision.May 7 2019, 5:56 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 7 2019, 5:56 PM
Harbormaster completed remote builds in B24137: Diff 57141.May 7 2019, 5:56 PM
ngie accepted this revision.May 8 2019, 11:31 PM

seemslegit

tests/sys/sys/splay_test.c
68–94

General comment (I know this is upstream code): testing against ITER/ITER-1 (because the splay is removed on 92) is ok, but it is a bit fragile in the event that more code is added in the middle of the two loops. It would be better to increment the maximum value, decrement when removing, then test against the new smaller maximum in the second loop.

71–74

That's an interesting way to handle collisions...

This revision is now accepted and ready to land.May 8 2019, 11:31 PM
Closed by commit rS347425: Add simple regression tests for tree(3). Those are ATF-ified versions (authored by trasz). · Explain WhyMay 10 2019, 7:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
tests/
sys/
sys/
2 lines
108 lines
108 lines

Diff 57141

View Options

tests/sys/sys/Makefile

Loading...
View Options

tests/sys/sys/rb_test.c

Loading...
View Options

tests/sys/sys/splay_test.c

Loading...