Differential D20185

Mark inline functions which are not neccessarily used, with unused.
ClosedPublic
Actions

Authored by trasz on May 7 2019, 5:53 PM.

Details

Reviewers

kib

Commits

rS347360: Mark inline functions with __unused; prevents compiler warning

Summary

Mark inline functions with unused; prevents compiler warning when they end up being unused.

Obtained from: OpenBSD

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24136
Build 22989: arc lint + arc unit

Event Timeline

trasz created this revision.May 7 2019, 5:53 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 7 2019, 5:53 PM

Harbormaster completed remote builds in B24136: Diff 57140.May 7 2019, 5:53 PM

It is very strange selection of functions. Why that set and not another ?

Either we mark some functions as __unused when we get specific warnings, or we mark everything. Look for instance at r321512.

Not sure what do you mean. I think I've marked all __inline functions there?

In D20185#434944, @trasz wrote:

Not sure what do you mean. I think I've marked all __inline functions there?

Well, the commit message should be very different then. 'Which are not neccessary used' does not imply 'all inlines (or static)', and of course I did not even look into 1KLoC file to confirm that.

That was copy/paste from OpenBSD's commit message, but okay. How about now?

kib accepted this revision.May 8 2019, 4:13 PM

This revision is now accepted and ready to land.May 8 2019, 4:13 PM

Closed by commit rS347360: Mark inline functions with __unused; prevents compiler warning (authored by trasz). · Explain WhyMay 8 2019, 6:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

tree.h

6 lines

Diff 57140

View Options

Mark __inline functions which are not neccessarily used, with __unused.ClosedPublicActions