shm magic.
ClosedPublic
Actions

Authored by dchagin on Jan 11 2015, 2:30 PM.

Details

Reviewers

emaste
trasz

Group Reviewers

Linux Emulation

Commits

rS283461: As for now our tmpfs is no longer being considered

Summary

As for now our tmpfs is no longer being considered "highly experimental" remove /dev/shm magic commited in r218497 and convert tmpfs type to an expected magic number.

Test Plan

rt/tst-shm test from glib-2.20

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dchagin updated this revision to Diff 3113.Jan 11 2015, 2:30 PM

dchagin retitled this revision from to Rework a bit /dev/shm magic..

dchagin updated this object.

dchagin edited the test plan for this revision. (Show Details)Jan 11 2015, 2:31 PM

dchagin added a reviewer: Linux Emulation.

dchagin added reviewers: trasz, emaste.Mar 25 2015, 7:15 PM

Out of curiosity, what did the deleted parts of code used to do, and why it's no longer needed?

In D1497#5, @trasz wrote:

Out of curiosity, what did the deleted parts of code used to do, and why it's no longer needed?

glibc 2.2 and above expects tmpfs to be mounted at /dev/shm for POSIX shared memory (shm_open, shm_unlink).
if /dev/shm is not mounted glibc tries (where_is_shmfs() method) all entries in /proc/mounts by statfs() sys call
and check f_type against SHMFS_SUPER_MAGIC.
So, removed code weird )))

trasz accepted this revision.Mar 31 2015, 12:27 PM

trasz edited edge metadata.

This revision is now accepted and ready to land.Mar 31 2015, 12:27 PM

Closed by commit rS283461: As for now our tmpfs is no longer being considered (authored by dchagin). · Explain WhyMay 24 2015, 5:27 PM

This revision was automatically updated to reflect the committed changes.