Page MenuHomeFreeBSD
Differential D20014

Move setting of console earlier in boot.
ClosedPublic
Actions

Authored by imp on Apr 22 2019, 5:53 PM.
Tags
None
Referenced Files
F137930575: D20014.id56503.diff
Thu, Nov 27, 9:16 AM
Unknown Object (File)
Mon, Nov 24, 3:22 AM
Unknown Object (File)
Sat, Nov 22, 6:34 PM
Unknown Object (File)
Thu, Nov 20, 5:54 PM
Unknown Object (File)
Thu, Nov 20, 5:53 PM
Unknown Object (File)
Thu, Nov 20, 5:52 PM
Unknown Object (File)
Thu, Nov 20, 5:41 PM
Unknown Object (File)
Wed, Nov 19, 4:35 AM
View All 82 Files
Subscribers
bcran
kevans

Details

Reviewers
kevans
Commits
rS346573: Move setting of console earlier in boot.
Summary

There's no reason we can't setup the console first thing after the
arch flags are setup. We set it undconditionally to efi. This is a
good default, and will get us error messages to at least the efi
console no matter what. This will also prime the pump so that as other
variables are set, they will take effect and the console will be
correct as soon as those env vars are set.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23826
Build 22766: arc lint + arc unit

Event Timeline

imp created this revision.Apr 22 2019, 5:53 PM
Herald added a subscriber: bcran. · View Herald TranscriptApr 22 2019, 5:53 PM
Harbormaster completed remote builds in B23826: Diff 56500.Apr 22 2019, 5:53 PM
kevans accepted this revision.Apr 22 2019, 6:03 PM
kevans added a subscriber: kevans.

I like it... I had mixed feelings about leaving the empty branches intact, but the commentary makes sense to keep.

This revision is now accepted and ready to land.Apr 22 2019, 6:03 PM
Closed by commit rS346573: Move setting of console earlier in boot. (authored by imp). · Explain WhyApr 22 2019, 6:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
stand/
efi/
loader/
24 lines

Diff 56500

View Options

stand/efi/loader/main.c

Loading...