Update to ksh 93v 2014-12-14
Includes patches to make it build on FreeBSD.
aarch64 is not supported due to missing sbrk(0)
Details
Details
- Reviewers
cy pi linimon pkubaj - Commits
- rP499547: shells/ksh93: Update to 93v 2014-12-24
Build ksh93 on pourdiere on supported platforms
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| shells/ksh93/Makefile | ||
|---|---|---|
| 16–17 ↗ | (On Diff #54340) | Use USE_GITHUB. |
Comment Actions
Can you please rework using -U99999? See https://wiki.freebsd.org/Phabricator.
Also USE_GITHUB as Mat recommends.
| shells/ksh93/Makefile | ||
|---|---|---|
| 16–17 ↗ | (On Diff #54340) | Using git hash of the release now. |
| shells/ksh93/Makefile | ||
|---|---|---|
| 28 ↗ | (On Diff #55003) | Why not use a git tag? e.g., slippy$ git tag commit 2f2b1b8be315df029ce83c2ccc12a16fdcf73f29 (tag: ksh93v, tag: 93v) The tag is self documenting. |
Comment Actions
All issues fixed
| shells/ksh93/Makefile | ||
|---|---|---|
| 28 ↗ | (On Diff #55003) | I have changed this to use the tag as suggested, thanks! |
Comment Actions
Except for possible USES=complier:c11 for gcc-based architectures, looks good. I'll commit it once Mark and Piotr have look.
| shells/ksh93/Makefile | ||
|---|---|---|
| 22 ↗ | (On Diff #55482) | We probably need USES=compiler:c11 here for gcc based platforms but since I cannot approximate that here on amd64 it's probably a good idea. I'll add linimon@ and pkubaj@ to reviewers to comment. |
| shells/ksh93/Makefile | ||
|---|---|---|
| 22 ↗ | (On Diff #55482) | ksh93 is written in a pretty oldschool and sometimes very interesting C ... Do you think this would help to solve the sbrk issue or is there any other reason for that? |
Comment Actions
It's not worth your time to support removal of sbrk() that has already been removed upstream long ago. Besides, att/ast are discussing releasing an alpha release this week. If they do release an alpha, it is suggested you take a copy of my ksh93-devel port and use it as a basis to simply change the tag. Ideally we would delete ksh93, then repocopy (svn copy) ksh93-devel to ksh93 and change the tag in one commit.
Comment Actions
Yes, this builds ok on powerpc64 when compiling with GCC8. So you should set USES=compiler:c11.
Comment Actions
Let's commit this. Any objections?
We can talk about how to implement the next upstream release (alpha, beta, or release) in another revision or PR.
Comment Actions
Hi Piotr, would that require clang60 as dependency on other platforms?
I think this port should compile even with gcc 4.2 or older ....
I must admit I don't understand why we need this option for powerpc64...
Comment Actions
I will commit this tomorrow or over the weekend so we can close the PR and move forward.
Comment Actions
Thank you @cy for taking care of this!
Now I seem to be getting a port monitor error:
Port | Current version | New version ------------------------------------------------+-----------------+------------ shells/ksh93 | 20141224 | 93v ------------------------------------------------+-----------------+------------
Would adding this help?
PORTSCOUT=limit:^\d{8}Comment Actions
This is because portscout performs a simple sort on $PORTVERSION. It will spam you only once. You can ignore it.
I received an email from one of the ksh93 developers. He apologized for the version numbering mess.
We should reconsider version numbering when PR/237332 is addressed.