Page MenuHomeFreeBSD
Differential D19980

netdump: Fix 11 compatibility DIOCSKERNELDUMP ioctl
ClosedPublic
Actions

Authored by cem on Apr 20 2019, 3:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 8:28 PM
Unknown Object (File)
Wed, May 1, 6:05 PM
Unknown Object (File)
Wed, May 1, 6:05 PM
Unknown Object (File)
Wed, May 1, 12:52 PM
Unknown Object (File)
Thu, Apr 25, 9:41 PM
Unknown Object (File)
Thu, Apr 25, 9:41 PM
Unknown Object (File)
Thu, Apr 25, 9:39 PM
Unknown Object (File)
Thu, Apr 25, 9:34 PM
View All 23 Files
Subscribers
imp
iz-rpi03_hs-karlsruhe.de

Details

Reviewers
markj
iz-rpi03_hs-karlsruhe.de
Commits
rS346448: netdump: Fix 11 compatibility DIOCSKERNELDUMP ioctl
Summary

The logic was present for the 11 version of the DIOCSKERNELDUMP ioctl, but
had not been updated for the 12 ABI.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23781
Build 22728: arc lint + arc unit

Event Timeline

cem created this revision.Apr 20 2019, 3:25 AM
Harbormaster completed remote builds in B23781: Diff 56416.Apr 20 2019, 3:25 AM
markj accepted this revision.Apr 20 2019, 10:38 AM
This revision is now accepted and ready to land.Apr 20 2019, 10:38 AM
Closed by commit rS346448: netdump: Fix 11 compatibility DIOCSKERNELDUMP ioctl (authored by cem). · Explain WhyApr 20 2019, 4:07 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptApr 20 2019, 4:07 PM
iz-rpi03_hs-karlsruhe.de reopened this revision.Apr 23 2019, 9:01 AM
iz-rpi03_hs-karlsruhe.de added a subscriber: iz-rpi03_hs-karlsruhe.de.

Now a kernel configuration without COMPAT_FREEBSD11 generates the following errror:

`--- netdump_client.o ---
/usr/src/sys/netinet/netdump/netdump_client.c:1143:8: error: unused variable 'u' [-Werror,-Wunused-variable]

u_int u;
      ^

1 error generated.
`

head/sys/netinet/netdump/netdump_client.c
1143 ↗(On Diff #56431)

Use #ifdef COMPAT_FREEBSD11 here as well.

cem added inline comments.Apr 23 2019, 4:52 PM
head/sys/netinet/netdump/netdump_client.c
1143 ↗(On Diff #56431)

Thanks for the catch!

iz-rpi03_hs-karlsruhe.de accepted this revision.Apr 24 2019, 7:16 AM

LGTM.
A kernel configuration without COMPAT_FREEBSD11 is building successfully again.

This revision is now accepted and ready to land.Apr 24 2019, 7:16 AM
cem closed this revision.Apr 27 2019, 6:51 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
netdump/
16 lines

Diff 56416

View Options

sys/netinet/netdump/netdump_client.c

Loading...