Differential D19846

Factor out section loading into a separate function
ClosedPublic
Actions

Authored by trasz on Apr 8 2019, 3:11 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 12 2025, 3:19 AM

	Unknown Object (File)
	Dec 11 2025, 3:15 AM

	Unknown Object (File)
	Nov 27 2025, 5:43 AM

	Unknown Object (File)
	Nov 24 2025, 10:48 AM

	Unknown Object (File)
	Nov 24 2025, 1:19 AM

	Unknown Object (File)
	Nov 23 2025, 6:53 AM

	Unknown Object (File)
	Nov 22 2025, 6:15 PM

	Unknown Object (File)
	Nov 21 2025, 11:11 AM

Subscribers

Details

Reviewers

Commits

rS346053: Factor out section loading into a separate function.

Summary

Factor out section loading into a separate function.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23593
Build 22582: arc lint + arc unit

Event Timeline

trasz created this revision.Apr 8 2019, 3:11 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 8 2019, 3:11 PM

Harbormaster completed remote builds in B23567: Diff 55944.Apr 8 2019, 3:11 PM

kib added inline comments.Apr 8 2019, 3:55 PM

sys/kern/imgact_elf.c
680	Indentation looks weird, this is because the block span is wrong. numsegs++ should be done regardless of != NULL. Perhaps rename numsegs to e.g. first_loadable and change type to boolean. After that, you can move assignment of zero to *base_addrp after the loop.

Fixes from kib@.

Harbormaster completed remote builds in B23593: Diff 55996.Apr 9 2019, 2:33 PM

trasz marked an inline comment as done.Apr 9 2019, 2:34 PM

kib accepted this revision.Apr 9 2019, 3:00 PM

This revision is now accepted and ready to land.Apr 9 2019, 3:00 PM

Closed by commit rS346053: Factor out section loading into a separate function. (authored by trasz). · Explain WhyApr 9 2019, 3:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

kern/

116 lines

Diff 55996

sys/kern/imgact_elf.c

Loading...