Differential D19741

Refactor ELF interpreter loading into a separate function.
ClosedPublic
Actions

Authored by trasz on Mar 28 2019, 10:22 PM.

Tags

None

Referenced Files

	F147323057: D19741.id55881.diff
	Mon, Mar 9, 11:35 PM

	F147249379: D19741.id55666.diff
	Mon, Mar 9, 10:45 AM

	F147236424: D19741.id55666.diff
	Mon, Mar 9, 8:30 AM

	F147217265: D19741.id55940.diff
	Mon, Mar 9, 5:06 AM

	F147215802: D19741.id55940.diff
	Mon, Mar 9, 4:51 AM

	Unknown Object (File)
	Fri, Mar 6, 8:05 PM

	Unknown Object (File)
	Fri, Mar 6, 5:56 AM

	Unknown Object (File)
	Fri, Mar 6, 12:41 AM

Subscribers

Details

Reviewers

Commits

rS346030: Refactor ELF interpreter loading into a separate function.

Summary

Refactor ELF interpreter loading into a separate function.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Mar 28 2019, 10:22 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 28 2019, 10:22 PM

Harbormaster completed remote builds in B23361: Diff 55566.Mar 28 2019, 10:22 PM

kib added inline comments.Mar 29 2019, 10:36 AM

sys/kern/imgact_elf.c
981 ↗	(On Diff #55566)	This block is irrelevant for the task of loading the interpreter. I must not be moved.

Rework a bit.

Harbormaster completed remote builds in B23431: Diff 55666.Apr 1 2019, 11:07 AM

trasz marked an inline comment as done.Apr 1 2019, 11:08 AM

kib added inline comments.Apr 1 2019, 12:54 PM

sys/kern/imgact_elf.c
961 ↗	(On Diff #55666)	This block of if() can be naturally moved before calculating newinterp.
971 ↗	(On Diff #55666)	How could newinterp != NULL and brand_info->interp_path == NULL ?

Reorder.

Harbormaster completed remote builds in B23435: Diff 55670.Apr 1 2019, 1:49 PM

trasz added inline comments.Apr 6 2019, 1:59 PM

sys/kern/imgact_elf.c
971 ↗	(On Diff #55666)	The newinterp comes from brand_info->interp_newpath, not brand_info->interp_path.

More rework - goto is done, as is the 'newinterp' variable.

Harbormaster completed remote builds in B23550: Diff 55881.Apr 6 2019, 2:35 PM

Looks fine, please test with 32bit binary.

This revision is now accepted and ready to land.Apr 6 2019, 3:07 PM

Closed by commit rS346030: Refactor ELF interpreter loading into a separate function. (authored by trasz). · Explain WhyApr 8 2019, 2:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

75 lines

Diff 55940

head/sys/kern/imgact_elf.c

Loading...