Page MenuHomeFreeBSD
Differential D19741

Refactor ELF interpreter loading into a separate function.
ClosedPublic
Actions

Authored by trasz on Mar 28 2019, 10:22 PM.
Tags
None
Referenced Files
F115041450: D19741.id55566.diff
Sat, Apr 19, 10:13 PM
Unknown Object (File)
Sat, Apr 19, 6:36 AM
Unknown Object (File)
Fri, Apr 11, 5:19 PM
Unknown Object (File)
Thu, Apr 10, 9:50 PM
Unknown Object (File)
Fri, Apr 4, 1:58 PM
Unknown Object (File)
Mar 13 2025, 11:50 PM
Unknown Object (File)
Feb 18 2025, 11:27 AM
Unknown Object (File)
Feb 3 2025, 12:40 AM
View All 79 Files
Subscribers
imp

Details

Reviewers
kib
Commits
rS346030: Refactor ELF interpreter loading into a separate function.
Summary

Refactor ELF interpreter loading into a separate function.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23435
Build 22449: arc lint + arc unit

Event Timeline

trasz created this revision.Mar 28 2019, 10:22 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 28 2019, 10:22 PM
Harbormaster completed remote builds in B23361: Diff 55566.Mar 28 2019, 10:22 PM
kib added inline comments.Mar 29 2019, 10:36 AM
sys/kern/imgact_elf.c
981

This block is irrelevant for the task of loading the interpreter. I must not be moved.

trasz updated this revision to Diff 55666.Apr 1 2019, 11:07 AM

Rework a bit.

Harbormaster completed remote builds in B23431: Diff 55666.Apr 1 2019, 11:07 AM
trasz marked an inline comment as done.Apr 1 2019, 11:08 AM
kib added inline comments.Apr 1 2019, 12:54 PM
sys/kern/imgact_elf.c
961

This block of if() can be naturally moved before calculating newinterp.

971

How could newinterp != NULL and brand_info->interp_path == NULL ?

trasz updated this revision to Diff 55670.Apr 1 2019, 1:49 PM

Reorder.

Harbormaster completed remote builds in B23435: Diff 55670.Apr 1 2019, 1:49 PM
trasz added inline comments.Apr 6 2019, 1:59 PM
sys/kern/imgact_elf.c
971

The newinterp comes from brand_info->interp_newpath, not brand_info->interp_path.

trasz updated this revision to Diff 55881.Apr 6 2019, 2:35 PM

More rework - goto is done, as is the 'newinterp' variable.

Harbormaster completed remote builds in B23550: Diff 55881.Apr 6 2019, 2:35 PM
kib accepted this revision.Apr 6 2019, 3:07 PM

Looks fine, please test with 32bit binary.

This revision is now accepted and ready to land.Apr 6 2019, 3:07 PM
Closed by commit rS346030: Refactor ELF interpreter loading into a separate function. (authored by trasz). · Explain WhyApr 8 2019, 2:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
kern/
81 lines

Diff 55670

View Options

sys/kern/imgact_elf.c

  • This file was added.
.\" Copyright (c) 2018 Murthy Bhat
.\" All rights reserved.
sbrunoUnsubmitted
Not Done
Inline Actions

Did Scott write this man page? Or is this from Microsemi?

sbruno: Did Scott write this man page? Or is this from Microsemi?
.\"
.\" Redistribution and use in source and binary forms, with or without
.\" modification, are permitted provided that the following conditions
.\" are met:
.\" 1. Redistributions of source code must retain the above copyright
.\" notice, this list of conditions and the following disclaimer.
.\" 2. Redistributions in binary form must reproduce the above copyright
.\" notice, this list of conditions and the following disclaimer in the
.\" documentation and/or other materials provided with the distribution.
.\"
.\" THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
.\" ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
.\" IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
.\" ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
.\" FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
.\" DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE.
.\"
.\" $FreeBSD$ stable/10/share/man/man4/smartpqi.4 195614 2017-01-11 08:10:18Z jkim $
.Dd April 06, 2018
sbrunoUnsubmitted
Not Done
Inline Actions

This syntax should be reset to:

.\" $FreeBSD$

This will allow the subversion server to insert the correct information.

sbruno: This syntax should be reset to: ``` .\" $FreeBSD$ ``` This will allow the subversion server…
sbrunoUnsubmitted
Not Done
Inline Actions

Please reset this syntax to:

.\" $FreeBSD$
sbruno: Please reset this syntax to: ``` .\" $FreeBSD$ ```
.Dt SMARTPQI 4
sbrunoUnsubmitted
Not Done
Inline Actions

Date should be updated.

sbruno: Date should be updated.
.Os
.Sh NAME
.Nm smartpqi
.Nd Microsemi smartpqi SCSI driver for PQI controllers
.Sh SYNOPSIS
To compile this driver into the kernel,
place the following lines in your
kernel configuration file:
.Bd -ragged -offset indent
.Cd device pci
.Cd device scbus
.Cd device smartpqi
.Pp
Alternatively, to load the driver as a
module at boot time, place the following line in
.Xr loader.conf 5 :
.Bd -literal -offset indent
smartpqi_load="YES"
.Ed
.Sh DESCRIPTION
The
.Nm
SCSI driver provides support for the new generation of PQI controllers from
Microsemi.
The
.Nm
driver is the first SCSI driver to implement the PQI queuing model.
.Pp
The
.Nm
driver will replace the aacraid driver for Adaptec Series 9 controllers.
.Pp
The
.Pa /dev/smartpqi?
device nodes provide access to the management interface of the controller.
One node exists per installed card.
.Sh HARDWARE
Controllers supported by the
.Nm
driver include:
.Pp
.Bl -bullet -compact
.It
HPE Gen10 Smart Array Controller Family
.It
OEM Controllers based on the Microsemi Chipset
.El
.Sh FILES
.Bl -tag -width /boot/kernel/aac.ko -compact
.It Pa /dev/smartpqi?
smartpqi management interface
.El
.Sh SEE ALSO
.Xr kld 4 ,
.Xr linux 4 ,
.Xr scsi 4 ,
.Xr kldload 8
.Xr pass 4
.Xr xpt 4
.Xr loader.conf 5
.Xr camcontrol 8
.Rs
.%T "Microsemi Website"
.%U http://www.microsemi.com/
.Re
.Sh HISTORY
The
.Nm
driver first appeared in
.Fx 11.1 .
.Sh AUTHOR
.An Murthy Bhat
.Aq murthy.bhat@microsemi.com
.Sh BUGS
sbrunoUnsubmitted
Not Done
Inline Actions

I certainly don't *remember* writing this man page. :-) Who is the actual author here?

sbruno: I certainly don't *remember* writing this man page. :-) Who is the actual author here?
sbrunoUnsubmitted
Not Done
Inline Actions

I'm still not an "author" of this man page.

sbruno: I'm still not an "author" of this man page.
The controller is not actually paused on suspend/resume.