Page MenuHomeFreeBSD

Mk/Uses/php.mk: Flag invalid args
ClosedPublic

Authored by tobik on Mar 29 2019, 11:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 3, 2:35 PM
Unknown Object (File)
Jan 12 2024, 11:49 PM
Unknown Object (File)
Dec 20 2023, 5:58 AM
Unknown Object (File)
Oct 17 2023, 6:19 PM
Unknown Object (File)
Oct 17 2023, 6:18 PM
Unknown Object (File)
Oct 17 2023, 6:18 PM
Unknown Object (File)
Oct 17 2023, 6:18 PM
Unknown Object (File)
Oct 17 2023, 5:54 PM
Subscribers

Details

Reviewers
ale
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Commits
rP497318: Mk/Uses/php.mk: Flag invalid args
Summary

Flag invalid USES=php arguments to avoid mistakes like

USES=		php:filter,gettext

instead of

USES=		php
USE_PHP=	filter gettext
Test Plan

Ran make -V IGNORE over the tree. The following ports had problems (I've already fixed them):

Origin						Invalid USES=php args			Fixed in
net-mgmt/nagiosql				filter gettext mysql session simplexml	rP497106
net-mgmt/glpi-plugins-fusioninventory-server	fileinfo (and simplexml, wddx [1])	rP497107

[1] Those are not flagged since USES=php is included multiple times.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 23396
Build 22413: arc lint + arc unit

Event Timeline

Mk/Uses/php.mk
7–8

I don't think "one of" is the correct wording, you can combine a few of them.

tobik marked an inline comment as done.
  • Update "Valid ARGS" comment with missing components
This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2019, 6:36 PM
This revision was automatically updated to reflect the committed changes.