Page MenuHomeFreeBSD
Differential D19750

Mk/Uses/php.mk: Flag invalid args
ClosedPublic
Actions

Authored by tobik on Mar 29 2019, 11:46 AM.
Tags
None
Referenced Files
F169466091: D19750.id55591.diff
Tue, Sep 1, 2:56 PM
F169384022: D19750.id55626.diff
Tue, Sep 1, 9:28 AM
F169324679: D19750.id55626.diff
Tue, Sep 1, 5:04 AM
F169286235: D19750.diff
Tue, Sep 1, 3:24 AM
F169223221: D19750.diff
Mon, Aug 31, 10:41 PM
Unknown Object (File)
Mon, Aug 31, 8:19 AM
Unknown Object (File)
Mon, Aug 31, 4:04 AM
Unknown Object (File)
Sun, Aug 30, 9:53 AM
View All Files
Subscribers
mat

Details

Reviewers
ale
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Commits
rP497318: Mk/Uses/php.mk: Flag invalid args
Summary

Flag invalid USES=php arguments to avoid mistakes like

USES=		php:filter,gettext

instead of

USES=		php
USE_PHP=	filter gettext
Test Plan

Ran make -V IGNORE over the tree. The following ports had problems (I've already fixed them):

Origin						Invalid USES=php args			Fixed in
net-mgmt/nagiosql				filter gettext mysql session simplexml	rP497106
net-mgmt/glpi-plugins-fusioninventory-server	fileinfo (and simplexml, wddx [1])	rP497107

[1] Those are not flagged since USES=php is included multiple times.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 23396
Build 22413: arc lint + arc unit

Event Timeline

tobik created this revision.Mar 29 2019, 11:46 AM
Owners added a reviewer: O5: Ports Framework.Mar 29 2019, 11:46 AM
Herald added a reviewer: portmgr. · View Herald TranscriptMar 29 2019, 11:46 AM
Herald added a subscriber: mat. · View Herald Transcript
Harbormaster completed remote builds in B23379: Diff 55591.Mar 29 2019, 11:46 AM
ale added inline comments.Mar 30 2019, 8:16 AM
Mk/Uses/php.mk
7–8

I don't think "one of" is the correct wording, you can combine a few of them.

tobik updated this revision to Diff 55616.Mar 30 2019, 8:42 AM
tobik marked an inline comment as done.
  • Update "Valid ARGS" comment with missing components
Harbormaster completed remote builds in B23396: Diff 55616.Mar 30 2019, 8:42 AM
ale accepted this revision.Mar 30 2019, 9:15 AM

LGTM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2019, 6:36 PM
Closed by commit rP497318: Mk/Uses/php.mk: Flag invalid args (authored by tobik). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
Mk/
Uses/
15 lines

Diff 55616

View Options

Mk/Uses/php.mk

Loading...