Page MenuHomeFreeBSD
Differential D19741

Refactor ELF interpreter loading into a separate function.
ClosedPublic
Actions

Authored by trasz on Mar 28 2019, 10:22 PM.
Tags
None
Referenced Files
F133381406: D19741.id55666.diff
Sat, Oct 25, 8:41 AM
F133344850: D19741.id55566.diff
Sat, Oct 25, 2:06 AM
F133344846: D19741.id55881.diff
Sat, Oct 25, 2:06 AM
F133344845: D19741.id55670.diff
Sat, Oct 25, 2:06 AM
F133344844: D19741.id55940.diff
Sat, Oct 25, 2:06 AM
F133344833: D19741.id.diff
Sat, Oct 25, 2:06 AM
Unknown Object (File)
Fri, Oct 24, 7:50 PM
Unknown Object (File)
Fri, Oct 24, 4:29 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
Commits
rS346030: Refactor ELF interpreter loading into a separate function.
Summary

Refactor ELF interpreter loading into a separate function.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23361
Build 22385: arc lint + arc unit

Event Timeline

trasz created this revision.Mar 28 2019, 10:22 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 28 2019, 10:22 PM
Harbormaster completed remote builds in B23361: Diff 55566.Mar 28 2019, 10:22 PM
kib added inline comments.Mar 29 2019, 10:36 AM
sys/kern/imgact_elf.c
981

This block is irrelevant for the task of loading the interpreter. I must not be moved.

trasz updated this revision to Diff 55666.Apr 1 2019, 11:07 AM

Rework a bit.

Harbormaster completed remote builds in B23431: Diff 55666.Apr 1 2019, 11:07 AM
trasz marked an inline comment as done.Apr 1 2019, 11:08 AM
kib added inline comments.Apr 1 2019, 12:54 PM
sys/kern/imgact_elf.c
961

This block of if() can be naturally moved before calculating newinterp.

971

How could newinterp != NULL and brand_info->interp_path == NULL ?

trasz updated this revision to Diff 55670.Apr 1 2019, 1:49 PM

Reorder.

Harbormaster completed remote builds in B23435: Diff 55670.Apr 1 2019, 1:49 PM
trasz added inline comments.Apr 6 2019, 1:59 PM
sys/kern/imgact_elf.c
971

The newinterp comes from brand_info->interp_newpath, not brand_info->interp_path.

trasz updated this revision to Diff 55881.Apr 6 2019, 2:35 PM

More rework - goto is done, as is the 'newinterp' variable.

Harbormaster completed remote builds in B23550: Diff 55881.Apr 6 2019, 2:35 PM
kib accepted this revision.Apr 6 2019, 3:07 PM

Looks fine, please test with 32bit binary.

This revision is now accepted and ready to land.Apr 6 2019, 3:07 PM
Closed by commit rS346030: Refactor ELF interpreter loading into a separate function. (authored by trasz). · Explain WhyApr 8 2019, 2:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
kern/
142 lines

Diff 55566

View Options

sys/kern/imgact_elf.c

Loading...