Page MenuHomeFreeBSD
Differential D17285

Modernize and flavourize p5-RT extension ports
ClosedPublic
Actions

Authored by matthew on Sep 22 2018, 11:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 27, 6:07 PM
Unknown Object (File)
Tue, Mar 24, 11:44 AM
Unknown Object (File)
Thu, Mar 19, 3:37 AM
Unknown Object (File)
Wed, Mar 18, 8:53 AM
Unknown Object (File)
Wed, Mar 18, 7:01 AM
Unknown Object (File)
Sun, Mar 15, 1:12 PM
Unknown Object (File)
Sun, Mar 15, 12:35 PM
Unknown Object (File)
Sun, Mar 15, 10:48 AM
View All Files
Subscribers
antoine
mat

Details

Reviewers
None
Group Reviewers
portmgr
Commits
rP497055: Modernize and flavourize RT Extension ports
Summary

Convert the RT{40,42,44} options to new rt42 and rt44 flavours.

Drop all references to www/rt40 -- no longer in ports

Default flavour is rt44, but several of these modules only support
rt42.

Ensure @rt42 flavour conflicts with www/rt44 port and vice-versa

Review by portmgr@ due to introduction of new flavours. This adds less than 10 additional
ports to the 'to build' list.

Re-order various sections and re-roll one patch to placate portlint

Update p5-RT-Extension-MandatoryOnTransition to 0.16; all other
modules get a PORTREVISION bump.

Test Plan

poudriere test builds; 10.4, 11.1 release; i386, amd64; all flavours.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 23271
Build 22306: arc lint + arc unit

Event Timeline

matthew created this revision.Sep 22 2018, 11:00 AM
Herald added a subscriber: mat. · View Herald TranscriptSep 22 2018, 11:00 AM
Harbormaster completed remote builds in B19750: Diff 48349.Sep 22 2018, 11:00 AM
matthew edited the summary of this revision. (Show Details)Sep 22 2018, 11:04 AM
matthew added a reviewer: portmgr.
matthew edited the summary of this revision. (Show Details)Sep 22 2018, 11:12 AM
antoine added a subscriber: antoine.Sep 23 2018, 9:24 AM

Is flavoring really needed? number of packages is exploding and now exp-run take several days to complete.

matthew added a comment.Sep 23 2018, 11:42 AM
In D17285#368660, @antoine wrote:

Is flavoring really needed? number of packages is exploding and now exp-run take several days to complete.

Flavoring here is about as necessary as it is for any other flavored packages: this is nothing special in that respect.
It's only a tiny increment in the number of packages compared to eg. adding PHP and Python flavors, and the packages
don't involve any compilation or other strenuous activity to generate.

mat added inline comments.Sep 24 2018, 12:23 PM
www/p5-RT-Authen-ExternalAuth/Makefile
22

Having one flavor makes very little sense.

www/p5-RT-Extension-CommandByMail/Makefile
20

So, this port really conflicts with the rt44 port? Should it not be p5-RT-Extension-CommandByMail-rt44?

24

It took me about a few minutes rereading of this line before understanding wtf it was doing.

Adding a a line with:

FLAVOR?=	${FLAVORS:[1]}

Would allow this to be a really more readable ${FLAVOR} == rt42.

www/p5-RT-Extension-Gravatar/Makefile
20

Same here.

24

Same here.

www/p5-RT-Extension-LDAPImport/Makefile
26

Same.

30

Same.

www/p5-RT-Extension-MandatoryOnTransition/Makefile
19

Same.

23

Same.

www/p5-RT-Extension-QuickAssign/Makefile
17–18

One flavor makes no sense.

www/p5-RT-Extension-SLA/Makefile
16–19

One flavor.

www/p5-RTx-Calendar/Makefile
24

same.

28

same.

38

Why +=?

matthew updated this revision to Diff 55401.Mar 24 2019, 1:47 PM
  • Import D17285 changes
  • Don't use flavours where there's only one choice. These modules are
  • No PORTREVISION bump if all we're doing is dropping support for the
  • Set FLAVOR so flavourization actually happens...
  • rtXX_PKGNAMEPREFIX should always end in a -
Harbormaster completed remote builds in B23270: Diff 55401.Mar 24 2019, 1:47 PM
matthew updated this revision to Diff 55402.Mar 24 2019, 1:56 PM
matthew marked 12 inline comments as done.
  • No need to test for undefinedness as we always set ${FLAVOR} a few
Harbormaster completed remote builds in B23271: Diff 55402.Mar 24 2019, 1:56 PM
matthew updated this revision to Diff 55403.Mar 24 2019, 2:00 PM
  • Fix longstanding error USES+=perl5 -> USES=perl5
Harbormaster completed remote builds in B23272: Diff 55403.Mar 24 2019, 2:00 PM
matthew added a comment.Mar 24 2019, 2:01 PM

Revive this review after far too long. Address all of @mat's points.

www/p5-RT-Extension-CommandByMail/Makefile
20

The rt42 flavoured port should conflict with rt44. I reworked this to use a PKGNAMEPREFIX as that seems to be the convention for add-on modules, rather than stand-alone applications.

matthew marked 2 inline comments as done.Mar 24 2019, 2:02 PM
mat accepted this revision as: portmgr.Mar 28 2019, 4:35 PM

I had a quick look, it looks good to me.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 28 2019, 7:26 PM
Closed by commit rP497055: Modernize and flavourize RT Extension ports (authored by matthew). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
www/
p5-RT-Authen-ExternalAuth/
36 lines
p5-RT-Extension-CommandByMail/
34 lines
p5-RT-Extension-Gravatar/
34 lines
p5-RT-Extension-LDAPImport/
49 lines
p5-RT-Extension-MandatoryOnTransition/
33 lines
p5-RT-Extension-QuickAssign/
25 lines
p5-RT-Extension-SLA/
35 lines
files/
6 lines
p5-RTx-Calendar/
45 lines

Diff 55402

View Options

www/p5-RT-Authen-ExternalAuth/Makefile

Loading...
View Options

www/p5-RT-Extension-CommandByMail/Makefile

Loading...
View Options

www/p5-RT-Extension-Gravatar/Makefile

Loading...
View Options

www/p5-RT-Extension-LDAPImport/Makefile

Loading...
View Options

www/p5-RT-Extension-MandatoryOnTransition/Makefile

Loading...
View Options

www/p5-RT-Extension-QuickAssign/Makefile

Loading...
View Options

www/p5-RT-Extension-SLA/Makefile

Loading...
View Options

www/p5-RT-Extension-SLA/files/patch-inc__Module__Install__RTx.pm

Loading...
View Options

www/p5-RTx-Calendar/Makefile

Loading...