Page MenuHomeFreeBSD
Differential D19508

x11-wm/libdockapp: Update to 0.7.2
ClosedPublic
Actions

Authored by kai on Mar 8 2019, 2:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 2:28 AM
Unknown Object (File)
Thu, Dec 19, 6:42 PM
Unknown Object (File)
Wed, Dec 4, 5:03 PM
Unknown Object (File)
Mon, Nov 25, 9:12 PM
Unknown Object (File)
Mon, Nov 25, 7:28 PM
Unknown Object (File)
Mon, Nov 25, 6:47 PM
Unknown Object (File)
Mon, Nov 25, 2:58 AM
Unknown Object (File)
Sun, Nov 24, 7:29 PM
View All Files
Subscribers
None

Details

Reviewers
miwi
tcberner
joneum
Commits
rP495736: x11-wm/libdockapp: Update to 0.7.2
Summary

While I'm here:

  • Change MASTER_SITES to upstream's new location
  • Add license and path to the license file
  • Sort variables a bit according to the PHB
  • Simplify pkg-plist substitution for the installation of example files

Also add patches beside just bumping the port revision for both ports due changed location of the header files:

  • net/wmnetload
  • x11/xscreensaver.app

Changelog:

https://github.com/d-torrance/dockapps/blob/master/libdockapp/ChangeLog

PR: 235923
Approved by: (one of the mentors), maintainer timeout

  • Add patches
Test Plan
  • poudriere (11.2-, 12.0-RELEASE, 13.0-CURRENT@r344874 amd64 + i386) -> OK
  • portlint -> OK
  • Runtime tests for net/wmnetload + x11/xscreensaver.app with new version of x11-wm/libdockapp -> OK

Note: This is required before D19136 can land (= "upgrade" astro/wmsun to 1.05)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kai created this revision.Mar 8 2019, 2:51 PM
Harbormaster completed remote builds in B22949: Diff 54835.Mar 8 2019, 2:51 PM
miwi requested changes to this revision.Mar 11 2019, 5:39 AM
miwi added inline comments.
x11-wm/libdockapp/Makefile
15 ↗(On Diff #54835)

can that be replace with USED= fonts?

This revision now requires changes to proceed.Mar 11 2019, 5:39 AM
kai added inline comments.Mar 11 2019, 10:09 AM
x11-wm/libdockapp/Makefile
15 ↗(On Diff #54835)

USES=fonts is already set on line 17 but as far I can tell from Mk/Uses/fonts.mk it only enables "mkfontdir" for RUN_DEPENDS when the arguments "fontsdir" or "fcfontsdir" are given.

When I omit the BUILD_DEPENDS line, the build fails in the configure phase with:

[...]
checking for mkfontdir... no
configure: error: mkfontdir is required to build libdockapp.
[...]
kai updated this revision to Diff 54988.Mar 12 2019, 3:28 PM

Rebased patch after rP495395 (x11-fonts/mkfontdir has been merged into x11-fonts/mkfontscale).

Harbormaster completed remote builds in B23042: Diff 54988.Mar 12 2019, 3:28 PM
miwi accepted this revision.Mar 14 2019, 12:29 PM

LGTM

This revision is now accepted and ready to land.Mar 14 2019, 12:29 PM
Closed by commit rP495736: x11-wm/libdockapp: Update to 0.7.2 (authored by kai). · Explain WhyMar 14 2019, 8:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
net/
wmnetload/
2 lines
files/
20 lines
11 lines
x11-wm/
libdockapp/
26 lines
5 lines
23 lines
x11/
xscreensaver.app/
2 lines
files/
11 lines

Diff 55077

View Options

head/net/wmnetload/Makefile

Loading...
View Options

head/net/wmnetload/files/patch-configure

Loading...
View Options

head/net/wmnetload/files/patch-src_wmnetload.c

Loading...
View Options

head/x11-wm/libdockapp/Makefile

Loading...
View Options

head/x11-wm/libdockapp/distinfo

Loading...
View Options

head/x11-wm/libdockapp/pkg-plist

Loading...
View Options

head/x11/xscreensaver.app/Makefile

Loading...
View Options

head/x11/xscreensaver.app/files/patch-xscreensaver.app.c

Loading...