Page MenuHomeFreeBSD

astro/wmsun: Change mastersite
Needs ReviewPublic

Authored by kai on Sat, Feb 9, 6:08 PM.

Details

Summary

PR 235526

While I'm here:

  • Add license information
Test Plan
  • File is fetchable at the new location
  • test build with poudriere (11.2-RELEASE amd64) to rule out any errors due the introduction of the license information -> OK
  • portlint is not quite happy about the short pkg-descr

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22414
Build 21574: arc lint + arc unit

Event Timeline

kai created this revision.Sat, Feb 9, 6:08 PM
tcberner added inline comments.Sat, Feb 9, 6:56 PM
astro/wmsun/pkg-descr
1

^ how about this one: https://www.dockapps.net/wmsun ... slightly older versions though... or is this unrelated to this one?

The whole thing looks a bit abandonware-y...

kai added a comment.Sat, Feb 9, 7:35 PM

The whole thing looks a bit abandonware-y...

astro/wmsun has a new home at https://github.com/window-maker/dockapps/tree/master/wmsun (which is also related in some way to https://www.dockapps.net/wmsun) but there's the latest version 1.05.

It might be possible that the current astro/wmsun is a fork that has ceased now. When comparing the ChangeLog files of the GitHub repo (https://github.com/window-maker/dockapps/blob/master/wmsun/ChangeLog) and in the currently used tarball there are some differences:

Github repo:

  • flawless continuation from 1.03 up to 1.05

Source tarball:

  • jumps from 1.03 to 1.10 with some remarks about the different upstream sources

AFAIK there would be two options:
a) Rename the port to astro/wmsun-fork (or similar) and deprecate it
b) switch to 1.05 from the GH repository and increase PORTEPOCH

What do you think about it?

In D19136#409263, @kai wrote:

The whole thing looks a bit abandonware-y...

astro/wmsun has a new home at https://github.com/window-maker/dockapps/tree/master/wmsun (which is also related in some way to https://www.dockapps.net/wmsun) but there's the latest version 1.05.

It might be possible that the current astro/wmsun is a fork that has ceased now. When comparing the ChangeLog files of the GitHub repo (https://github.com/window-maker/dockapps/blob/master/wmsun/ChangeLog) and in the currently used tarball there are some differences:

Github repo:

  • flawless continuation from 1.03 up to 1.05

    Source tarball:
  • jumps from 1.03 to 1.10 with some remarks about the different upstream sources

    AFAIK there would be two options: a) Rename the port to astro/wmsun-fork (or similar) and deprecate it b) switch to 1.05 from the GH repository and increase PORTEPOCH

    What do you think about it?

I would prefer b), then it has a proper upstream and not some shadily versioned tar from a dead upstream :)

kai added a comment.Mon, Feb 11, 1:13 PM

AFAIK there would be two options:
a) Rename the port to astro/wmsun-fork (or similar) and deprecate it
b) switch to 1.05 from the GH repository and increase PORTEPOCH

What do you think about it?

I would prefer b), then it has a proper upstream and not some shadily versioned tar from a dead upstream :)

Indeed and I was able to gather some more infos meanwhile:

The official version 1.05 requires an updated x11-wm/libdockapp (which is available in the official repository, too). But I did also some quick runtime test of the "new" astro/wmsun and the program crashes upon startup.

To keep it short: A bit more work is required to bring the port into the right shape.

kai edited the test plan for this revision. (Show Details)Thu, Feb 21, 9:11 PM