PR 235914
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 22842 Build 21930: arc lint + arc unit
Event Timeline
| x11-themes/materia-gtk-theme/Makefile | ||
|---|---|---|
| 32 | Is COPYING necessary here? The license file is installed in "licenses" directory as well. | |
| 44 | PORTDOCS= --> PORTDOCS+= ? | |
| 48 | Should this be ${STAGEDIR}${PREFIX}/share/themes ? | |
| 57 | Removing top-level README.md's seems unnecessary since they are not installed in each theme directory. | |
Comment Actions
Please don't remove gnome-shell stuff because it is used in the install.sh script to determine which version of gnome-shell-related material should be installed.
(The install script assumes gnome version is 3.30, which is not supported by FreeBSD, without gnome-shell installed.)
I guess the folloing changes make sense:
- Removing NO_BUILD=yes
- Define do-build target which make install.sh determine gnome version and copy necessary files to temporary build directory
- Let do-install target COPYTREE_SHARE the contents of build directory to stage directory
Can I update the patch file within a couple of days?
| x11-themes/materia-gtk-theme/Makefile | ||
|---|---|---|
| 23 | I wanted to make it clear that this port is GTK/Gnome theme because there is a materia theme for KDE as well. But I'm indifferent. materia-theme is fine with me. | |
| x11-themes/materia-gtk-theme/Makefile | ||
|---|---|---|
| 23 | There is a matching Materia theme for KDE. | |
| 32 | Yes. There is no "licenses" directory. If upstream doesn't do it automatically at the install time that will not be in the ${DOCSDIR} if the port doesn't take care of it. :-) | |
| 32 | There is another was PORTDOCS in the GNOMESHELL OPTION. | |
| 39 | Good point! I was sure I've saw on the install file it would detect the gnome-shell presence on-the-fly to add or not the gnome-shell theme; however testing it now I see it is added anyway. So if that was true no-gnome user would need to build half gnome just to get one gtk theme. ^^ | |
| 44 | That is in the previous/general one. ^^ | |
| 48 | Yes, thank you. | |
| 57 | Yes, they are. I got tons of them after running make makeplist. ^^ | |
Comment Actions
It did yesterday when I used arc patch and tried it. Show me the code that is not working.
| x11-themes/materia-gtk-theme/Makefile | ||
|---|---|---|
| 44–53 | Don't use both do- and post- for the same stage, put everything in do-install. | |