Page MenuHomeFreeBSD

x11-themes/materia-gtk-theme: New Port - Material Design theme
ClosedPublic

Authored by rigoletto on Feb 24 2019, 11:36 PM.

Details

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Improve documentation leftovers remotion.

tagattie_yandex.com added inline comments.
x11-themes/materia-gtk-theme/Makefile
31 ↗(On Diff #54322)

Is COPYING necessary here? The license file is installed in "licenses" directory as well.

43 ↗(On Diff #54322)

PORTDOCS= --> PORTDOCS+= ?

47 ↗(On Diff #54322)

Should this be ${STAGEDIR}${PREFIX}/share/themes ?

56 ↗(On Diff #54322)

Removing top-level README.md's seems unnecessary since they are not installed in each theme directory.

Fix "themes" directory creation.

x11-themes/materia-gtk-theme/Makefile
22 ↗(On Diff #54325)

^ why not use that as the portname?

31 ↗(On Diff #54325)

^ why += ?

38 ↗(On Diff #54325)

^ there should be some toggle for that for the build system to turn it on and off -- which kind of contradicts NO_BUILD -- why do you need it present?

rigoletto marked 3 inline comments as done.

Removing gnome-shell stuff.

Removing gnome-shell stuff.

Please don't remove gnome-shell stuff because it is used in the install.sh script to determine which version of gnome-shell-related material should be installed.
(The install script assumes gnome version is 3.30, which is not supported by FreeBSD, without gnome-shell installed.)

I guess the folloing changes make sense:

  • Removing NO_BUILD=yes
  • Define do-build target which make install.sh determine gnome version and copy necessary files to temporary build directory
  • Let do-install target COPYTREE_SHARE the contents of build directory to stage directory

Can I update the patch file within a couple of days?

x11-themes/materia-gtk-theme/Makefile
22 ↗(On Diff #54325)

I wanted to make it clear that this port is GTK/Gnome theme because there is a materia theme for KDE as well. But I'm indifferent. materia-theme is fine with me.

Revert the last changes, plus removing NO_BUILD.

x11-themes/materia-gtk-theme/Makefile
42–44 ↗(On Diff #54435)
GNOMESHELL_PORTDOCS=....
53–54 ↗(On Diff #54435)

PORTDOCS contains files, why use COPYTREE_SHARE and not INSTALL_DATA?

@mat GNOMESHELL_PORTDOCS isn't working. The file isn't added to PORTDOCS.

rigoletto added inline comments.
x11-themes/materia-gtk-theme/Makefile
31 ↗(On Diff #54322)

Yes. There is no "licenses" directory. If upstream doesn't do it automatically at the install time that will not be in the ${DOCSDIR} if the port doesn't take care of it. :-)

43 ↗(On Diff #54322)

That is in the previous/general one. ^^

47 ↗(On Diff #54322)

Yes, thank you.

56 ↗(On Diff #54322)

Yes, they are. I got tons of them after running make makeplist. ^^

22 ↗(On Diff #54325)

There is a matching Materia theme for KDE.

31 ↗(On Diff #54325)

There is another was PORTDOCS in the GNOMESHELL OPTION.

38 ↗(On Diff #54325)

Good point! I was sure I've saw on the install file it would detect the gnome-shell presence on-the-fly to add or not the gnome-shell theme; however testing it now I see it is added anyway.

So if that was true no-gnome user would need to build half gnome just to get one gtk theme. ^^

No need for for --> ${PORTDOCS}

@mat GNOMESHELL_PORTDOCS isn't working. The file isn't added to PORTDOCS.

It did yesterday when I used arc patch and tried it. Show me the code that is not working.

Yes, probably was a problem with a previous installation setup.

Thank you.

x11-themes/materia-gtk-theme/Makefile
43–52 ↗(On Diff #54654)

Don't use both do- and post- for the same stage, put everything in do-install.

rigoletto marked an inline comment as done.

Merge post-install into do-install.

This revision is now accepted and ready to land.Mar 4 2019, 8:53 PM
This revision was automatically updated to reflect the committed changes.