Differential D19271

Define a constant for the maximum number of GEOM_CTL arguments.
ClosedPublic
Actions

Authored by markj on Feb 20 2019, 3:48 PM.

Tags

None

Referenced Files

	F146166244: D19271.diff
	Sat, Feb 28, 9:37 AM

	F146148324: D19271.diff
	Sat, Feb 28, 5:50 AM

	Unknown Object (File)
	Thu, Feb 26, 5:33 PM

	Unknown Object (File)
	Wed, Feb 11, 6:49 AM

	Unknown Object (File)
	Wed, Feb 11, 3:36 AM

	Unknown Object (File)
	Tue, Feb 10, 7:01 PM

	Unknown Object (File)
	Sun, Feb 8, 5:28 AM

	Unknown Object (File)
	Sun, Feb 8, 12:30 AM

View All 95 Files

Subscribers

imp

Details

Reviewers

eugen_grosbein.net

Commits

rS344365: Define a constant for the maximum number of GEOM_CTL arguments.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22620
Build 21733: arc lint + arc unit

Event Timeline

markj created this revision.Feb 20 2019, 3:48 PM

Harbormaster completed remote builds in B22620: Diff 54139.Feb 20 2019, 3:48 PM

eugen_grosbein.net added a reviewer: eugen_grosbein.net.Feb 20 2019, 4:00 PM

eugen_grosbein.net added inline comments.

sys/geom/geom_ctl.h
83	If PATH_GEOM_CTL has only file name and no path component, why does it have PATH_ in the name?

markj added inline comments.Feb 20 2019, 4:04 PM

sys/geom/geom_ctl.h
83	Seems like a historical mistake.

eugen_grosbein.net accepted this revision.Feb 20 2019, 4:47 PM

This revision is now accepted and ready to land.Feb 20 2019, 4:47 PM

Closed by commit rS344365: Define a constant for the maximum number of GEOM_CTL arguments. (authored by markj). · Explain WhyFeb 20 2019, 5:07 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptFeb 20 2019, 5:07 PM

Revision Contents
Changeset List

Path

Size

sys/

geom/

geom_ctl.h

3 lines

geom_ctl.c

2 lines

Diff 54139

View Options

sys/geom/geom_ctl.h