Page MenuHomeFreeBSD

misc/xiphos: Unbreak build
ClosedPublic

Authored by kai on Feb 16 2019, 12:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 3, 10:31 PM
Unknown Object (File)
Sun, Mar 3, 10:31 PM
Unknown Object (File)
Sun, Mar 3, 10:31 PM
Unknown Object (File)
Sun, Mar 3, 10:31 PM
Unknown Object (File)
Sat, Mar 2, 7:08 PM
Unknown Object (File)
Jan 18 2024, 1:02 AM
Unknown Object (File)
Dec 30 2023, 5:43 AM
Unknown Object (File)
Dec 30 2023, 5:43 AM
Subscribers
None

Details

Summary

PR 232997

  • Unbreak build by adding "-ftemplate-depth=1024" to CXXFLAGS
  • Add missing libraries

While I'm here:

  • Fix license and add path to license file
  • Add "gnome" to USES because using USE_GNOME alone is deprecated
  • Pet portlint
Test Plan
  • poudriere (11.2-, 12.0-RELEASE, 13.0-CURRENT@r342772 amd64 + i386) -> OK
  • portlint -> OK (just warns about the BUILD_DEPENDS=${RUN_DEPENDS} [...] construct)
  • Runtime tests -> OK

It builds also fine on the 2019Q1 branch for the case if a MFH is required/accepted.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 22563
Build 21696: arc lint + arc unit

Event Timeline

misc/xiphos/Makefile
33

there should be no need for ".

  • Removed double-quotes from the CXXFLAGS value
kai marked an inline comment as done.Feb 18 2019, 11:48 PM
kai added inline comments.
misc/xiphos/Makefile
33

Ok, the double-quotes are removed.

This revision is now accepted and ready to land.Feb 19 2019, 1:44 PM
This revision was automatically updated to reflect the committed changes.
kai marked an inline comment as done.