Diff Detail
- Repository
- rD FreeBSD doc repository - subversion
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
|---|---|---|
| 4242 | Spelling error, I think: s/garanties/guarantees/ | |
| en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
|---|---|---|
| 4242 | google translate agrees with you :-) | |
| en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
|---|---|---|
| 4129 | This sentence goes in a circle from "when a port needs" to "dependencies the port needs". It is really at least two sentences. Try to be declarative rather than using an if/then structure ("when" is better than if, but there is still a pause after it). Maybe: Ports that need Xfce libraries or applications set USES=xfce. Specific dependencies are set with values assigned to USE_XFCE as shown below. | |
| 4167 | "current" is a little unclear. Does it mean "the list of dependencies that can be declared"? | |
| 4180 | What does "own" mean? "Custom"? (And it should be capitalized in this title.) | |
| 4183 | No "s" on "specific", and it would be more understandable with a dash (and no comma after "widgets"): <application>GTK3</application>-specific widgets <package | |
| 4241–4246 | This sentence is kind of hard to understand. The previous sentence says "There is no need to list the components..." But then this one seems to contradict that. Maybe. There are two different starts to the sentence: Note, however, that, So... what is this really trying to say? | |
| 4242 | Well, s/guarantees/guarantee/ but the meaning is still fuzzy. | |
| en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml | ||
| 1387 | s/port/the port/ | |
| en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
|---|---|---|
| 4167 | It means that in doubt, this file contains the reference code as the handbook may lag a bit. Maybe I should merge this paragraph and the one before the list. I'll try that. | |
| 4180 | I have no idea, I don't use either Xfce or GTK3. Maybe the order of the words is wrong and it should be "Using Xfce's own GTK3 widgets" | |
| 4241–4246 | you must list all the dependencies the port needs to build, and not count on a dependency to bring in something as it could change. | |
Correct a few @wblock's comments, reword a few things, and convert the
itemizelist to a variablelist.
| en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
|---|---|---|
| 4132 | I like this. | |
| 4217 | No comma needed here. There is no pause, it just says "X uses A and B." | |
| 4241–4246 | Aha! So is this xfce components included this way will automatically include any dependencies they need. However, xfce components and non-xfce dependencies of the port must be included explicitly. Do not count on an xfce component to provide a sub-dependency other than itself for the main port. (An example might help.) | |
| en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
|---|---|---|
| 4214 | I don't really have an example, I added that bit to remind people that THEY SHALL LIST ALL DEPENDENCIES EXPLICITLY :-) | |
Adding @olivierd here, he sent the original PR, I would like be sure that I did not change too much the spirit of things and wrote nonsense.
Management of xfce components is new with Xfce 4.12. In previous releases (<= 4.12) in Makefile we need to list each components explicitly, now it's not necessary, we use the same behaviour as GNOME.
E.g., misc/xfce4-weather-plugin (it's panel plugin)
Before (Xfce 4.12) xfce components are libmenu, libutil, and panel
Now, xfce component is panel, dependencies are automatically checked (libexo, garcon, libmenu, xfconf, libutil).
On our wiki page, there's a graph [1] which shows connection between each xfce components. In pink central point, often use in Makefiles.
I think it's more simple.
Why use GTK3 argument?
Because in x11/libxfce4menu (this port provides Xfce's specific widgets), they are built on top of GTK2, and GTK3 (optional, set by default).
Parole (multimedia player) requires these new widgets, and as most of Xfce's applications still use only GTK2 toolkit. If user build his own ports and unset this option, we need to check if these new widgets are installed or not.
[1] https://wiki.freebsd.org/Xfce?action=AttachFile&do=view&target=xfce4.png
It looks like this addresses Warren's comments, so okay by me. (Please wait for Warren to comment before commit first, in case there is something outstanding from his comments.)
Phabricator seems a bit confused, and the comments are not lining up with the sections they refer to. It's hard to tell, but I think most things are fixed except the "libraries" and "applications" thing.
| en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
|---|---|---|
| 4129 | Still needs | |