Differential D19006

ipfilter #ifdef cleanup
ClosedPublic
Actions

Authored by cy on Jan 28 2019, 8:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 2, 3:56 AM

	Unknown Object (File)
	Wed, May 1, 9:37 PM

	Unknown Object (File)
	Sat, Apr 20, 2:19 PM

	Unknown Object (File)
	Sat, Apr 20, 2:19 PM

	Unknown Object (File)
	Sat, Apr 20, 2:18 PM

	Unknown Object (File)
	Thu, Apr 18, 2:16 PM

	Unknown Object (File)
	Mar 22 2024, 9:50 PM

	Unknown Object (File)
	Mar 22 2024, 9:50 PM

View All 51 Files

Subscribers

Details

Reviewers

Commits

rS344833: MFC r343701 & r343732:
rS343701: ipfilter #ifdef cleanup.

Summary

Remove #ifdefs for ancient and irrelevant operating systemsfrom
ipfilter.

When ipfilter was written the UNIX and UNIX-like systems in use
were various and plentiful. IRIX, Tru64 (OSF/1) don't exist any
more. OpenBSD removed ipfilter during the first time the license
terms changed in the early 2000's. ipfilter on AIX, HP/UX, and
Linux never really caught on. Removal of code for operating systems
that ipfilter will never run on again will simplify the code making
it easier to fix bugs, complete partially implemented features, and
extend ipfilter.

What remains is FreeBSD, NetBSD, and illumos. FreeBSD and NetBSD have
collaborated exchanging patches while illumos has expressed willingness
to have their ipfilter updated to current, provided their zone-specific
updates to their ipfilter are merged (which are of interest to
FreeBSD to allow control of ipfilters in jails from the global zone).

Test Plan

make tinderbox completed successfully on universe13b.

Running on my local ipfilter firewall and laptop.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 22229

Event Timeline

cy created this revision.Jan 28 2019, 8:56 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 28 2019, 8:56 PM

Harbormaster completed remote builds in B22229: Diff 53344.Jan 28 2019, 8:56 PM

I should also mention that this also removes support for older versions of FreeBSD.

Very happy to see this.

btw, what is the status of ipfilter wrt upstream merges? Are there going to be any? If no, then it probably should move from sys/contrib to sys/netpfil.

This revision is now accepted and ready to land.Jan 29 2019, 4:28 PM

My emails to Darren are unanswered. I asked Christos Zoulas (christos@netbsd.org) to check in on Darren. He told me Darren is taking a hiatus from ipfilter and doesn't know when he will be back. I want to discuss this with Christos first (as it appears he's still in contact with Darren), maybe at BSDCan (if I can go). I'll make my decision after that.

Closed by commit rS343701: ipfilter #ifdef cleanup. (authored by cy). · Explain WhyApr 13 2019, 5:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

contrib/

ipfilter/

12 lines

14 lines

83 lines

ip_fil_compat.c

47 lines

20 lines

ipsend/

.OLD/

118 lines

2 lines

2 lines

4 lines

2 lines

10 lines

7 lines

16 lines

2 lines

13 lines

22 lines

2 lines

7 lines

4 lines

lib/

3 lines

8 lines

2 lines

79 lines

13 lines

7 lines

tools/

9 lines

9 lines

45 lines

158 lines

43 lines

16 lines

9 lines

6 lines

2 lines

sys/

contrib/

ipfilter/

netinet/

64 lines

52 lines

35 lines

14 lines

82 lines

15 lines

8 lines

8 lines

6 lines

76 lines

10 lines

5 lines

61 lines

20 lines

10 lines

27 lines

ip_raudio_pxy.c

8 lines

10 lines

15 lines

54 lines

Diff 53344

contrib/ipfilter/arc4random.c

Loading...

contrib/ipfilter/ip_dstlist.c

Loading...

contrib/ipfilter/ip_fil.c

Loading...

contrib/ipfilter/ip_fil_compat.c

Loading...

contrib/ipfilter/ipf.h

Loading...

contrib/ipfilter/ipsend/.OLD/ip_compat.h

Loading...

contrib/ipfilter/ipsend/44arp.c

Loading...

contrib/ipfilter/ipsend/arp.c

Loading...

contrib/ipfilter/ipsend/dlcommon.c

Loading...

contrib/ipfilter/ipsend/ip.c

Loading...

contrib/ipfilter/ipsend/ipresend.c

Loading...

contrib/ipfilter/ipsend/ipsend.h

Loading...

contrib/ipfilter/ipsend/ipsend.c

Loading...

contrib/ipfilter/ipsend/ipsopt.c

Loading...

contrib/ipfilter/ipsend/iptest.c

Loading...

contrib/ipfilter/ipsend/iptests.c

Loading...

contrib/ipfilter/ipsend/resend.c

Loading...

contrib/ipfilter/ipsend/sdlpi.c

Loading...

contrib/ipfilter/ipsend/sock.c

Loading...

contrib/ipfilter/lib/getifname.c

Loading...

contrib/ipfilter/lib/getproto.c

Loading...

contrib/ipfilter/lib/inet_addr.c

Loading...

contrib/ipfilter/lib/kmem.c

Loading...

contrib/ipfilter/lib/printproto.c

Loading...

contrib/ipfilter/md5.c

Loading...

contrib/ipfilter/tools/ipf.c

Loading...

contrib/ipfilter/tools/ipfs.c

Loading...

contrib/ipfilter/tools/ipfstat.c

Loading...

contrib/ipfilter/tools/ipftest.c

Loading...

contrib/ipfilter/tools/ipmon.c

Loading...

contrib/ipfilter/tools/ipnat.c

Loading...

contrib/ipfilter/tools/ipnat_y.y

Loading...

contrib/ipfilter/tools/ippool.c

Loading...

contrib/ipfilter/tools/ippool_y.y

Loading...

sys/contrib/ipfilter/netinet/fil.c

Loading...

sys/contrib/ipfilter/netinet/ip_auth.c

Loading...

sys/contrib/ipfilter/netinet/ip_compat.h

Loading...

sys/contrib/ipfilter/netinet/ip_dstlist.c

Loading...

sys/contrib/ipfilter/netinet/ip_fil.h

Loading...

sys/contrib/ipfilter/netinet/ip_frag.c

Loading...

sys/contrib/ipfilter/netinet/ip_ftp_pxy.c

Loading...

sys/contrib/ipfilter/netinet/ip_htable.c

Loading...

sys/contrib/ipfilter/netinet/ip_irc_pxy.c

Loading...

sys/contrib/ipfilter/netinet/ip_log.c

Loading...

sys/contrib/ipfilter/netinet/ip_lookup.c

Loading...

sys/contrib/ipfilter/netinet/ip_nat.h

Loading...

sys/contrib/ipfilter/netinet/ip_nat.c

Loading...

sys/contrib/ipfilter/netinet/ip_nat6.c

Loading...

sys/contrib/ipfilter/netinet/ip_pool.c

Loading...

sys/contrib/ipfilter/netinet/ip_proxy.c

Loading...

sys/contrib/ipfilter/netinet/ip_raudio_pxy.c

Loading...

sys/contrib/ipfilter/netinet/ip_scan.c

Loading...

sys/contrib/ipfilter/netinet/ip_state.c

Loading...

sys/contrib/ipfilter/netinet/ip_sync.c

Loading...