Page MenuHomeFreeBSD
Differential D18882

Fix pfsync breaking carp
ClosedPublic
Actions

Authored by smh on Jan 18 2019, 12:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 1, 8:06 AM
Unknown Object (File)
Sun, Dec 28, 11:05 PM
Unknown Object (File)
Fri, Dec 26, 12:35 PM
Unknown Object (File)
Dec 11 2025, 6:13 AM
Unknown Object (File)
Dec 9 2025, 7:06 AM
Unknown Object (File)
Nov 27 2025, 5:28 AM
Unknown Object (File)
Nov 17 2025, 8:43 PM
Unknown Object (File)
Oct 30 2025, 3:14 PM
View All Files
Subscribers
farrokhi
imp

Details

Reviewers
kp
Commits
rS343130: pf: fix pfsync breaking carp
Summary

Fix missing initialisation of sc_flags into a valid sync state on clone which breaks carp in pfsync.

This regression was introduce by 342051

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22013
Build 21246: arc lint + arc unit

Event Timeline

smh created this revision.Jan 18 2019, 12:13 AM
Herald added subscribers: farrokhi, imp. · View Herald TranscriptJan 18 2019, 12:14 AM
Harbormaster completed remote builds in B22013: Diff 52954.Jan 18 2019, 12:14 AM
smh added a reviewer: kp.Jan 18 2019, 12:16 AM
kp added a comment.Jan 18 2019, 12:41 AM

Yeah, looking at my original commit I did manage to lose that flag. I’ve not tested yet, but this patch is almost certainly correct.

I’ll take a deeper look and commit later today.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 18 2019, 8:20 AM
Closed by commit rS343130: pf: fix pfsync breaking carp (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
1 line

Diff 52954

View Options

sys/netpfil/pf/if_pfsync.c

Loading...