Differential D18723

biosdisk needs to use std probe for floppy devices
ClosedPublic
Actions

Authored by tsoome on Jan 2 2019, 8:41 PM.

Details

Reviewers: None
Commits: rS342785: With buggy int13 ah=15, we can mis-identify the floppy devices.

Summary

With buggy int13 ah=15, we can mis-identify the floppy devices.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21814
Build 21082: arc lint + arc unit

Event Timeline

tsoome created this revision.Jan 2 2019, 8:41 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 2 2019, 8:41 PM

Harbormaster completed remote builds in B21814: Diff 52497.Jan 2 2019, 8:41 PM

Are we *guaranteed* to have the floppy drives coming only at the start of the list?

In D18723#399420, @yuripv wrote:

Are we *guaranteed* to have the floppy drives coming only at the start of the list?

There is no such thing as *guaranteed* in the BIOS world. However, the fact about hard disks starting from 0x80 and floppy drives starting from 0 (or hdd's having high bit set:) is so fundamental that I hope they do not dare to break it:) In any case, if this fact is broken, all but trivial boot loaders are broken.

gor_clogic.com.ua added a subscriber: gor_clogic.com.ua.Jan 3 2019, 8:11 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 5 2019, 7:20 AM

Closed by commit rS342785: With buggy int13 ah=15, we can mis-identify the floppy devices. (authored by tsoome). · Explain Why

This revision was automatically updated to reflect the committed changes.