Differential D18675

Fix build of devel/mdb.
ClosedPublic
Actions

Authored by jhb on Dec 28 2018, 7:01 PM.

Details

Reviewers

zeising

Commits

rP488620: Fix build of devel/mdb.

Summary

Include bsd.port.pre.mk before using SRC_BASE.
Add a missing file to the packing list.
Bump PORTREVISION.

Test Plan

currently it always fails to build as SRC_BASE is now empty. Not sure when this changed, but 12.0 and later at least are broken.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 21755
Build 21031: arc lint + arc unit

Event Timeline

jhb created this revision.Dec 28 2018, 7:01 PM

Herald added a subscriber: mat. · View Herald TranscriptDec 28 2018, 7:01 PM

Harbormaster completed remote builds in B21754: Diff 52377.Dec 28 2018, 7:01 PM

zeising accepted this revision.Dec 28 2018, 7:04 PM

zeising added a subscriber: zeising.

This comment was removed by zeising.

This revision is now accepted and ready to land.Dec 28 2018, 7:04 PM

zeising requested changes to this revision.Dec 28 2018, 7:05 PM

zeising added inline comments.

devel/mdb/Makefile
38	Should be bsd.port.post.mk

This revision now requires changes to proceed.Dec 28 2018, 7:05 PM

Use bsd.port.post.mk.
Fix plist.

Harbormaster completed remote builds in B21755: Diff 52378.Dec 28 2018, 7:15 PM

jhb retitled this revision from Include bsd.port.pre.mk before using SRC_BASE. to Fix build of devel/mdb..Dec 28 2018, 7:16 PM

jhb edited the summary of this revision. (Show Details)

lgtm

This revision is now accepted and ready to land.Dec 28 2018, 7:20 PM

Closed by commit rP488620: Fix build of devel/mdb. (authored by jhb). · Explain WhyDec 28 2018, 7:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

devel/

mdb/

Makefile

5 lines

pkg-plist

1 line

Diff 52378

View Options

devel/mdb/Makefile