Simplify the way we set the default sh(1) PS1. No functional changes.
ClosedPublic
Actions

Authored by trasz on Dec 27 2018, 2:15 PM.

Details

Reviewers

jilles

Commits

rS342576: Simplify the way we set the default sh(1) PS1. No functional changes.

Summary

Simplify the way we set the default sh(1) PS1. No functional changes.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Dec 27 2018, 2:15 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 27 2018, 2:15 PM

Harbormaster completed remote builds in B21737: Diff 52335.Dec 27 2018, 2:15 PM

trasz added a reviewer: jilles.Dec 27 2018, 2:15 PM

Use \h.

Harbormaster completed remote builds in B21738: Diff 52337.Dec 27 2018, 2:22 PM

It seems like the idea is that we're stuck with that ugly \h/\$ bashism anyway so we might as well use it.

share/skel/dot.shrc
36 ↗	(On Diff #52337)	Can the `whoami` invocation be changed to `$USER`? This would remove the final fork from the prompt setup.

trasz added inline comments.Dec 28 2018, 2:23 PM

share/skel/dot.shrc
36 ↗	(On Diff #52337)	I'm not sure about that one. For example the $USER is not updated during 'su' (it is when using 'su -' instead).

jilles accepted this revision.Dec 28 2018, 2:41 PM

jilles added inline comments.

share/skel/dot.shrc
36 ↗	(On Diff #52337)	OK, no need to change it then.

This revision is now accepted and ready to land.Dec 28 2018, 2:41 PM

Closed by commit rS342576: Simplify the way we set the default sh(1) PS1. No functional changes. (authored by trasz). · Explain WhyDec 28 2018, 5:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

share/

skel/

dot.shrc

6 lines

Diff 52373

View Options

Simplify the way we set the default sh(1) PS1. No functional changes.ClosedPublicActions