Page MenuHomeFreeBSD
Differential D18605

Allow multi-byte thousands separators in strfmon(3)
ClosedPublic
Actions

Authored by cem on Dec 19 2018, 2:29 AM.
Tags
None
Referenced Files
F168662326: D18605.id52177.diff
Sat, Aug 29, 12:21 PM
F168605497: D18605.id.diff
Sat, Aug 29, 5:52 AM
Unknown Object (File)
Fri, Aug 28, 2:34 PM
Unknown Object (File)
Thu, Aug 27, 10:50 AM
Unknown Object (File)
Thu, Aug 27, 8:48 AM
Unknown Object (File)
Thu, Aug 27, 5:39 AM
Unknown Object (File)
Tue, Aug 25, 8:50 PM
Unknown Object (File)
Tue, Aug 25, 8:50 PM
View All Files
Subscribers
imp

Details

Reviewers
yuripv
Commits
rS342260: Allow multi-byte thousands separators in strfmon(3)
Summary

PR: 234010
Reported by: Jon Tejnung <jon AT herrskogen.se>

Test Plan

ATF test case included.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21638
Build 20931: arc lint + arc unit

Event Timeline

cem created this revision.Dec 19 2018, 2:29 AM
Harbormaster completed remote builds in B21638: Diff 52155.Dec 19 2018, 2:29 AM
yuripv accepted this revision.Dec 19 2018, 6:31 PM

Looks good to me, I have even applied the patch and tested some corner cases I could think of :-)

This revision is now accepted and ready to land.Dec 19 2018, 6:31 PM
cem added a comment.Dec 19 2018, 6:38 PM

Thanks!

Closed by commit rS342260: Allow multi-byte thousands separators in strfmon(3) (authored by cem). · Explain WhyDec 19 2018, 10:58 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptDec 19 2018, 10:58 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
stdlib/
37 lines
tests/
stdlib/
1 line
71 lines

Diff 52155

View Options

lib/libc/stdlib/strfmon.c

Loading...
View Options

lib/libc/tests/stdlib/Makefile

Loading...
View Options

lib/libc/tests/stdlib/strfmon_test.c

Loading...