Page MenuHomeFreeBSD
Differential D18605

Allow multi-byte thousands separators in strfmon(3)
ClosedPublic
Actions

Authored by cem on Dec 19 2018, 2:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 21, 9:20 AM
Unknown Object (File)
Sun, Sep 20, 8:55 AM
Unknown Object (File)
Sun, Sep 13, 3:51 AM
Unknown Object (File)
Sun, Sep 13, 3:51 AM
Unknown Object (File)
Sun, Sep 13, 3:40 AM
Unknown Object (File)
Fri, Sep 11, 9:33 AM
Unknown Object (File)
Fri, Sep 11, 7:18 AM
Unknown Object (File)
Sun, Sep 6, 2:42 PM
View All Files
Subscribers
imp

Details

Reviewers
yuripv
Commits
rS342260: Allow multi-byte thousands separators in strfmon(3)
Summary

PR: 234010
Reported by: Jon Tejnung <jon AT herrskogen.se>

Test Plan

ATF test case included.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21638
Build 20931: arc lint + arc unit

Event Timeline

cem created this revision.Dec 19 2018, 2:29 AM
Harbormaster completed remote builds in B21638: Diff 52155.Dec 19 2018, 2:29 AM
yuripv accepted this revision.Dec 19 2018, 6:31 PM

Looks good to me, I have even applied the patch and tested some corner cases I could think of :-)

This revision is now accepted and ready to land.Dec 19 2018, 6:31 PM
cem added a comment.Dec 19 2018, 6:38 PM

Thanks!

Closed by commit rS342260: Allow multi-byte thousands separators in strfmon(3) (authored by cem). · Explain WhyDec 19 2018, 10:58 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptDec 19 2018, 10:58 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
stdlib/
37 lines
tests/
stdlib/
1 line
71 lines

Diff 52155

View Options

lib/libc/stdlib/strfmon.c

Loading...
View Options

lib/libc/tests/stdlib/Makefile

Loading...
View Options

lib/libc/tests/stdlib/strfmon_test.c

Loading...