Page MenuHomeFreeBSD

[new port] sysutils/py-azure-cli-base: Add Azure CLI to the ports tree
ClosedPublic

Authored by dbaio on Dec 15 2018, 5:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 6:10 AM
Unknown Object (File)
Fri, Nov 8, 2:34 PM
Unknown Object (File)
Sun, Oct 27, 11:58 AM
Unknown Object (File)
Oct 20 2024, 6:19 PM
Unknown Object (File)
Oct 19 2024, 2:32 PM
Unknown Object (File)
Oct 4 2024, 4:53 AM
Unknown Object (File)
Oct 2 2024, 9:03 AM
Unknown Object (File)
Oct 1 2024, 7:12 AM

Details

Summary

Now with all dependencies. Full diff here.

Add Mk/Uses/azurepy.mk, based on devel/py-backports[1] because all
py-azure-* ports conflicts with each other.

1 - https://reviews.freebsd.org/D11095

Feedbacks are welcome.

Thank you!

Test Plan
$ az --help

Group
    az

Subgroups:
    account           : Manage Azure subscription information.
    acr               : Manage private registries with Azure Container Registries.
    acs  [Deprecated] : Manage Azure Container Services.
    ad                : Manage Azure Active Directory Graph entities needed for Role Based Access
                        Control.
    advisor           : Manage Azure Advisor.
    aks               : Manage Azure Kubernetes Services.
    ams               : Manage Azure Media Services resources.
    appservice        : Manage App Service plans.
    backup            : Manage Azure Backups.
    batch             : Manage Azure Batch.
    batchai           : Manage Batch AI resources.
    billing           : Manage Azure Billing.
    bot               : Manage Microsoft Bot Services.
    cdn               : Manage Azure Content Delivery Networks (CDNs).
    cloud             : Manage registered Azure clouds.
    cognitiveservices : Manage Azure Cognitive Services accounts.
    consumption       : Manage consumption of Azure resources.
    container         : Manage Azure Container Instances.
    cosmosdb          : Manage Azure Cosmos DB database accounts.
    deployment        : Manage Azure Resource Manager deployments at subscription scope.
    disk              : Manage Azure Managed Disks.
    dla               : (PREVIEW) Manage Data Lake Analytics accounts, jobs, and catalogs.
    dls               : (PREVIEW) Manage Data Lake Store accounts and filesystems.
    dms               : Manage Azure Data Migration Service (DMS) instances.
    eventgrid         : Manage Azure Event Grid topics and subscriptions.
    eventhubs         : Manage Azure Event Hubs namespaces, eventhubs, consumergroups and geo
                        recovery configurations - Alias.
    extension         : Manage and update CLI extensions.
    feature           : Manage resource provider features.
    functionapp       : Manage function apps.
    group             : Manage resource groups and template deployments.
    hdinsight         : Manage HDInsight clusters.
    identity          : Managed Service Identities.
    image             : Manage custom virtual machine images.
    iot               : Manage Internet of Things (IoT) assets.
    iotcentral        : Manage IoT Central assets.
    keyvault          : Manage KeyVault keys, secrets, and certificates.
    lab               : Manage Azure DevTest Labs.
    lock              : Manage Azure locks.
    managedapp        : Manage template solutions provided and maintained by Independent Software
                        Vendors (ISVs).
    maps              : Manage Azure Maps.
    mariadb           : Manage Azure Database for MariaDB servers.
    monitor           : Manage the Azure Monitor Service.
    mysql             : Manage Azure Database for MySQL servers.
    network           : Manage Azure Network resources.
    policy            : Manage resource policies.
    postgres          : Manage Azure Database for PostgreSQL servers.
    provider          : Manage resource providers.
    redis             : Manage dedicated Redis caches for your Azure applications.
    relay             : Manage Azure Relay Service namespaces, WCF relays, hybrid connections, and
                        rules.
    reservations      : Manage Azure Reservations.
    resource          : Manage Azure resources.
    role              : Manage user roles for access control with Azure Active Directory and service
                        principals.
    search            : Manage Azure Search services, admin keys and query keys.
    servicebus        : Manage Azure Service Bus namespaces, queues, topics, subscriptions, rules
                        and geo-disaster recovery configuration alias.
    sf                : Manage and administer Azure Service Fabric clusters.
    sig               : Manage shared image gallery.
    signalr           : Manage Azure SignalR Service.
    snapshot          : Manage point-in-time copies of managed disks, native blobs, or other
                        snapshots.
    sql               : Manage Azure SQL Databases and Data Warehouses.
    tag               : Manage resource tags.
    vm                : Manage Linux or Windows virtual machines.
    vmss              : Manage groupings of virtual machines in an Azure Virtual Machine Scale Set
                        (VMSS).
    webapp            : Manage web apps.

Commands:
    configure         : Manage Azure CLI configuration. This command is interactive.
    feedback          : Send feedback to the Azure CLI Team!
    find              : Find Azure CLI commands.
    interactive       : Start interactive mode. Installs the Interactive extension if not installed
                        already.
    login             : Log in to Azure.
    logout            : Log out to remove access to Azure subscriptions.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 21636
Build 20929: arc lint + arc unit

Event Timeline

dbaio edited the test plan for this revision. (Show Details)
dbaio added reviewers: mat, antoine, koobs, lifanov, sunpoet.
dbaio set the repository for this revision to rP FreeBSD ports repository.
dbaio edited the test plan for this revision. (Show Details)

Now with fewer dependencies. Full diff here.
What do you think about having a Mk/Uses/azurepy.mk?

Regards.

Mk/Uses/azurepy.mk
12–22

This should probably always be there, and not use a specific target name like all the other uses do.

sysutils/py-azure-cli-base/Makefile
22–49

Please use one pkg-plist file and it will work correctly for both python versions.

Now using target USES_install after post-install SEQ and
a single pkg-plist with Python PLIST_SUB helpers.
Thank you.

sysutils/py-azure-cli-base/pkg-plist
5–20 ↗(On Diff #52181)

All this should not be needed, the same plist should work with both python2 and python3, maybe with using USE_PYTHON=py3kplist

sysutils/py-azure-cli-base/pkg-plist
5 ↗(On Diff #52181)

Also, never use %%PYTHON_PYOEXTENSION%% for a python2 only line.

Please feel free to become a maintainer of this port, we are not using it anymore and I will not be in track of it

Please feel free to become a maintainer of this port, we are not using it anymore and I will not be in track of it

Thanks!
@all This is in regard of PR 234268.

Addressing pkg-plist issues, thanks.

dbaio marked 2 inline comments as done.

Looks ok now. Do tell me that the USES will be used by more than three ports.

In D18573#397762, @mat wrote:

Looks ok now. Do tell me that the USES will be used by more than three ports.

There will be about 90 ports using this USES.

This is the current patch I'm working on, I need to check/add other 18 dependencies:
py-azure-cli-v030.patch

All functionalities/commands of azure-cli are a separate project/port, with its own dependencies.

When it's done, could I add the USES with an approved by portmgr?

Thank you.

In D18573#397762, @mat wrote:

Looks ok now. Do tell me that the USES will be used by more than three ports.

There will be about 90 ports using this USES.

It was what I thought, but I wanted to be sure :-)

This is the current patch I'm working on, I need to check/add other 18 dependencies:
py-azure-cli-v030.patch

All functionalities/commands of azure-cli are a separate project/port, with its own dependencies.

When it's done, could I add the USES with an approved by portmgr?

Well, if the USES does not change, yes. It would probably be best create reviews so that other pairs of eyes look at updated patches, in any way.

Include guards are missing from Mk/Uses/azurepy.mk

dbaio edited the summary of this revision. (Show Details)
dbaio edited the test plan for this revision. (Show Details)

Add include guards on Mk/Uses/azurepy.mk, thanks antoine@

Now with all dependencies. Full diff here.

linimon retitled this revision from Add Azure CLI to the ports tree to [new port] sysutils/py-azure-cli-base: Add Azure CLI to the ports tree.Jan 15 2019, 8:21 PM

Hi @mat and @antoine.

With the last update, could I push this USES and the new ports?
Or do you prefer a separate review for this new USES?

And for all the new ports, could they be committed together or is better individual commits?

Thank you again.

mat added inline comments.
Mk/Uses/azurepy.mk
14

Maybe move this just before the target.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 26 2019, 12:52 PM
This revision was automatically updated to reflect the committed changes.