Differential D18315

science/erkale: Please approve flavorization: serial and parallel
ClosedPublic
Actions

Authored by yuri on Nov 23 2018, 9:47 PM.

Tags

None

Referenced Files

	F83539122: D18315.id51091.diff
	Sat, May 11, 8:49 PM

	Unknown Object (File)
	Fri, May 10, 9:56 PM

	Unknown Object (File)
	Fri, May 10, 6:46 AM

	Unknown Object (File)
	Thu, May 9, 8:13 PM

	Unknown Object (File)
	Wed, May 1, 10:22 PM

	Unknown Object (File)
	Wed, May 1, 10:22 PM

	Unknown Object (File)
	Wed, May 1, 10:22 PM

	Unknown Object (File)
	Wed, May 1, 9:14 PM

View All 47 Files

Subscribers

Contributor Reviewers (ports)

Details

Reviewers

Commits

rP487568: science/erkale: Please approve flavorization: serial and parallel

Summary

Serial and parallel version can be installed concurrently.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuri created this revision.Nov 23 2018, 9:47 PM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptNov 23 2018, 9:47 PM

Harbormaster completed remote builds in B21179: Diff 51020.Nov 23 2018, 9:47 PM

mat added inline comments.Nov 24 2018, 9:40 AM

science/erkale/Makefile
24 ↗	(On Diff #51020)	Please use flavor helpers.
45–47 ↗	(On Diff #51020)	Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

Fix location.

yuri marked 2 inline comments as done.Nov 24 2018, 9:53 AM

yuri added inline comments.

science/erkale/Makefile
24 ↗	(On Diff #51020)	Like this: serial_PKGNAMESUFFIX= -serial parallel_PKGNAMESUFFIX= -parallel ? It is 2 lines, isn't it worse?

Harbormaster completed remote builds in B21190: Diff 51040.Nov 24 2018, 9:53 AM

mat added inline comments.Nov 25 2018, 11:52 AM

science/erkale/Makefile
24 ↗	(On Diff #51020)	No, it is more clear, also, you may want to only change the package name for the non default option, as people running pkg upgrade will not get the new package.

Use helpers.

yuri marked 2 inline comments as done.Nov 25 2018, 6:33 PM

Harbormaster completed remote builds in B21199: Diff 51091.Nov 25 2018, 6:36 PM

mat added inline comments.Nov 26 2018, 8:55 AM

science/erkale/Makefile
24 ↗	(On Diff #51091)	Remove this one.

.

Harbormaster completed remote builds in B21203: Diff 51110.Nov 26 2018, 9:04 AM

mat accepted this revision.Dec 6 2018, 3:32 PM

This revision is now accepted and ready to land.Dec 6 2018, 3:32 PM

Closed by commit rP487568: science/erkale: Please approve flavorization: serial and parallel (authored by yuri). · Explain WhyDec 16 2018, 9:21 AM

This revision was automatically updated to reflect the committed changes.

yuri mentioned this in rP487568: science/erkale: Please approve flavorization: serial and parallel.

Revision Contents
Changeset List

Path

Size

head/

science/

erkale/

54 lines

6 lines

183 lines

Diff 52074

head/science/erkale/Makefile

Loading...

head/science/erkale/distinfo

Loading...

head/science/erkale/pkg-plist

Loading...