Differential D18315

science/erkale: Please approve flavorization: serial and parallel
ClosedPublic
Actions

Authored by yuri on Nov 23 2018, 9:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mar 9 2024, 12:15 AM

	Unknown Object (File)
	Jan 10 2024, 10:42 AM

	Unknown Object (File)
	Dec 23 2023, 2:17 AM

	Unknown Object (File)
	Nov 26 2023, 8:17 AM

	Unknown Object (File)
	Nov 14 2023, 8:22 AM

	Unknown Object (File)
	Nov 12 2023, 8:23 AM

	Unknown Object (File)
	Nov 11 2023, 7:11 AM

	Unknown Object (File)
	Nov 10 2023, 9:01 PM

View All 35 Files

Subscribers

Contributor Reviewers (ports)

Details

Reviewers

Commits

rP487568: science/erkale: Please approve flavorization: serial and parallel

Summary

Serial and parallel version can be installed concurrently.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 21190
Build 20544: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 23 2018, 9:47 PM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptNov 23 2018, 9:47 PM

Harbormaster completed remote builds in B21179: Diff 51020.Nov 23 2018, 9:47 PM

mat added inline comments.Nov 24 2018, 9:40 AM

science/erkale/Makefile
24	Please use flavor helpers.
45–47	Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

Fix location.

yuri marked 2 inline comments as done.Nov 24 2018, 9:53 AM

yuri added inline comments.

science/erkale/Makefile
24	Like this: serial_PKGNAMESUFFIX= -serial parallel_PKGNAMESUFFIX= -parallel ? It is 2 lines, isn't it worse?

Harbormaster completed remote builds in B21190: Diff 51040.Nov 24 2018, 9:53 AM

mat added inline comments.Nov 25 2018, 11:52 AM

science/erkale/Makefile
24	No, it is more clear, also, you may want to only change the package name for the non default option, as people running pkg upgrade will not get the new package.

Use helpers.

yuri marked 2 inline comments as done.Nov 25 2018, 6:33 PM

Harbormaster completed remote builds in B21199: Diff 51091.Nov 25 2018, 6:36 PM

mat added inline comments.Nov 26 2018, 8:55 AM

science/erkale/Makefile
24	Remove this one.

.

Harbormaster completed remote builds in B21203: Diff 51110.Nov 26 2018, 9:04 AM

mat accepted this revision.Dec 6 2018, 3:32 PM

This revision is now accepted and ready to land.Dec 6 2018, 3:32 PM

Closed by commit rP487568: science/erkale: Please approve flavorization: serial and parallel (authored by yuri). · Explain WhyDec 16 2018, 9:21 AM

This revision was automatically updated to reflect the committed changes.

yuri mentioned this in rP487568: science/erkale: Please approve flavorization: serial and parallel.

Revision Contents
Changeset List

Path

Size

science/

erkale/

53 lines

6 lines

183 lines

Diff 51040

science/erkale/Makefile

Loading...

science/erkale/distinfo

Loading...

science/erkale/pkg-plist

Loading...