Fix possible double free in bwn_{dma,pio}_tx_start().
ClosedPublic
Actions

Authored by markj on Nov 26 2018, 2:37 PM.

Details

Reviewers

Commits

rS341990: Fix a possible mbuf double free in bwn_dma_tx_start().

Summary

The caller of bwn_{dma,pio}_tx_start() frees the mbuf if the call fails.
The tx_start routines may call m_defrag() which frees the input mbuf
chain upon success; if the routines fail after successfully calling
m_defrag(), we will free the mbuf chain twice.

Test Plan

None; I don't have any hardware which uses this driver.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Nov 26 2018, 2:37 PM

markj edited the test plan for this revision. (Show Details)Nov 26 2018, 2:38 PM

markj added a reviewer: landonf.

Harbormaster completed remote builds in B21205: Diff 51118.Nov 26 2018, 2:38 PM

This looks good to me; I'll try to test on real hardware over the weekend, just to be sure.

In D18342#393604, @landonf wrote:

This looks good to me; I'll try to test on real hardware over the weekend, just to be sure.

Thanks!

Sorry to nag, but did you get a chance to test this?

In D18342#394419, @markj wrote:

Sorry to nag, but did you get a chance to test this?

Apologies, wasn't able to get to it until tonight; other than the small KASSERT ordering issue, everything seems to be fine on a real hardware.

Fix assert ordering issue.

Harbormaster completed remote builds in B21510: Diff 51892.Dec 12 2018, 2:59 AM

In D18342#394805, @landonf wrote:

In D18342#394419, @markj wrote:

Sorry to nag, but did you get a chance to test this?

Apologies, wasn't able to get to it until tonight; other than the small KASSERT ordering issue, everything seems to be fine on a real hardware.