jack_gandi.net retitled this revision from Summary: review https://reviews.freebsd.org/D18359 introduced bug for getfhat(2) with NULL path. to review D18359 introduced bug forgetfhat(2) with NULL path..Dec 10 2018, 3:39 PM

jack_gandi.net retitled this revision from review D18359 introduced bug forgetfhat(2) with NULL path. to fix getfhat bug introduced by D18359.

jack_gandi.net edited the summary of this revision. (Show Details)

I clearly missed this in the original commit. Why do you need this special-case 'dot' behaviour ? Why cannot getfhat() behave same as openat(2) WRT NULL path ?

The dot special behaviour was because our application is currently using getfhat with a NULL path. We'll fix this in the application rather than in kernel code. I've rolled back to a behaviour similar to openat, also amended the manpage.

Harbormaster completed remote builds in B21477: Diff 51820.Dec 10 2018, 5:00 PM

kib accepted this revision.Dec 10 2018, 5:25 PM

This revision is now accepted and ready to land.Dec 10 2018, 5:25 PM

Closed by commit rS341809: Remove special case handling for getfhat(fd, NULL, handle). (authored by kib). · Explain WhyDec 11 2018, 2:49 AM

This revision was automatically updated to reflect the committed changes.

Herald added a reviewer: manpages. · View Herald TranscriptDec 11 2018, 2:49 AM

Herald added a subscriber: imp. · View Herald Transcript