Page MenuHomeFreeBSD
Differential D18459

Const poison the command interface
ClosedPublic
Actions

Authored by imp on Dec 6 2018, 6:25 PM.
Tags
None
Referenced Files
F155000839: D18459.id.diff
Thu, Apr 30, 2:42 PM
Unknown Object (File)
Thu, Apr 23, 3:53 AM
Unknown Object (File)
Mon, Apr 20, 1:23 PM
Unknown Object (File)
Sun, Apr 19, 3:29 PM
Unknown Object (File)
Sun, Apr 19, 3:29 PM
Unknown Object (File)
Thu, Apr 16, 6:37 AM
Unknown Object (File)
Wed, Apr 15, 8:29 AM
Unknown Object (File)
Tue, Apr 7, 4:37 AM
View All 95 Files
Subscribers
None

Details

Reviewers
cem
Commits
rS341658: Const poison the command interface
Summary

Make the pointers we pass into the commands const, also make the
linker set mirrors const.

Suggested by: cem@
Sponsored by: Netflix

Test Plan

made a separate commit because it seemed needlessly churny to include it in the other one.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21404
Build 20728: arc lint + arc unit

Event Timeline

imp created this revision.Dec 6 2018, 6:25 PM
Harbormaster completed remote builds in B21404: Diff 51675.Dec 6 2018, 6:25 PM
imp edited the test plan for this revision. (Show Details)Dec 6 2018, 6:26 PM
imp added a reviewer: cem.
cem accepted this revision.Dec 6 2018, 10:43 PM
This revision is now accepted and ready to land.Dec 6 2018, 10:43 PM
Closed by commit rS341658: Const poison the command interface (authored by imp). · Explain WhyDec 6 2018, 10:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sbin/
nvmecontrol/
2 lines
2 lines
2 lines
6 lines
6 lines
26 lines
16 lines
8 lines
2 lines
2 lines
2 lines
6 lines

Diff 51675

View Options

sbin/nvmecontrol/devlist.c

Loading...
View Options

sbin/nvmecontrol/firmware.c

Loading...
View Options

sbin/nvmecontrol/format.c

Loading...
View Options

sbin/nvmecontrol/identify.c

Loading...
View Options

sbin/nvmecontrol/logpage.c

Loading...
View Options

sbin/nvmecontrol/ns.c

Loading...
View Options

sbin/nvmecontrol/nvmecontrol.h

Loading...
View Options

sbin/nvmecontrol/nvmecontrol.c

Loading...
View Options

sbin/nvmecontrol/perftest.c

Loading...
View Options

sbin/nvmecontrol/power.c

Loading...
View Options

sbin/nvmecontrol/reset.c

Loading...
View Options

sbin/nvmecontrol/wdc.c

Loading...