Page MenuHomeFreeBSD
Differential D18452

Add device_delete_children(9) manual page
ClosedPublic
Actions

Authored by asmodai on Dec 6 2018, 4:16 PM.
Tags
None
Referenced Files
F171129370: D18452.id52777.diff
Tue, Sep 8, 9:30 PM
F170969769: D18452.diff
Mon, Sep 7, 10:31 PM
Unknown Object (File)
Mon, Sep 7, 2:05 AM
Unknown Object (File)
Sun, Sep 6, 11:19 PM
Unknown Object (File)
Sun, Sep 6, 3:44 PM
Unknown Object (File)
Sun, Sep 6, 3:11 PM
Unknown Object (File)
Sun, Sep 6, 3:07 PM
Unknown Object (File)
Sun, Sep 6, 9:25 AM
View All Files
Subscribers
imp
yuripv

Details

Reviewers
None
Group Reviewers
Doc Committers
manpages
Commits
rS342948: Add man page for device_delete_children.
Summary

Add a device_delete_children(9) manual page based on the comments in code.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21394
Build 20719: arc lint + arc unit

Event Timeline

asmodai created this revision.Dec 6 2018, 4:16 PM
Herald added a reviewer: manpages. · View Herald TranscriptDec 6 2018, 4:16 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B21394: Diff 51655.Dec 6 2018, 4:16 PM
imp added inline comments.Dec 6 2018, 7:25 PM
share/man/man9/device_delete_children.9
49

Do we need to document the error codes?

yuripv added a subscriber: yuripv.Dec 8 2018, 9:04 PM
yuripv added inline comments.
share/man/man9/device_delete_children.9
36

(here and below) I'm not a native speaker so could very wrong.. Shouldn't this read "child devices" instead?

41

Add double quotes around device_t dev.

43

It's usually written as the following even if there's only one function discussed.

The
.Fn device_delete_children
function ...
asmodai updated this revision to Diff 51954.Dec 13 2018, 3:14 PM

Address feedback from yuripv.

Harbormaster completed remote builds in B21536: Diff 51954.Dec 13 2018, 3:16 PM
asmodai updated this revision to Diff 51955.Dec 13 2018, 3:27 PM

Fix forgotten mention of children

Harbormaster completed remote builds in B21537: Diff 51955.Dec 13 2018, 3:30 PM
asmodai marked 3 inline comments as done.Dec 13 2018, 3:40 PM
asmodai added inline comments.
share/man/man9/device_delete_children.9
36

You are correct. I did some checking on various English grammar fora and it seems to be a mistaken use of children, indeed. You talk about "deleting the children from a device", but "deleting the child devices".

asmodai marked an inline comment as done and an inline comment as not done.Dec 13 2018, 3:41 PM
asmodai updated this revision to Diff 51956.Dec 13 2018, 3:42 PM

Clarify return values.

Harbormaster completed remote builds in B21538: Diff 51956.Dec 13 2018, 3:44 PM
asmodai marked 3 inline comments as done.Dec 13 2018, 3:44 PM
asmodai added inline comments.
share/man/man9/device_delete_children.9
49

@imp Hopefully this should clarify the return values.

asmodai updated this revision to Diff 51957.Dec 13 2018, 3:47 PM
asmodai marked an inline comment as done.

Add Makefile entry back.

Harbormaster completed remote builds in B21539: Diff 51957.Dec 13 2018, 3:47 PM
asmodai added a comment.Jan 11 2019, 2:45 PM

If this is acceptable, could someone commit it? I don't have commit rights anymore, so can't add it myself.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 11 2019, 7:05 PM
Closed by commit rS342948: Add man page for device_delete_children. (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
share/
man/
man9/
1 line
56 lines

Diff 51655

View Options

share/man/man9/Makefile

Loading...
View Options

share/man/man9/device_delete_children.9

Loading...