Page MenuHomeFreeBSD
Differential D18263

sfxge(4): prevent access to the NIC config before probe
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 2:06 AM
Unknown Object (File)
Fri, Apr 18, 11:46 AM
Unknown Object (File)
Wed, Apr 16, 7:45 AM
Unknown Object (File)
Mon, Apr 14, 8:08 AM
Unknown Object (File)
Mon, Apr 14, 4:26 AM
Unknown Object (File)
Sun, Apr 13, 10:48 PM
Unknown Object (File)
Sun, Apr 13, 9:32 PM
Unknown Object (File)
Sat, Apr 12, 12:32 AM
View All 42 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS342517: MFC r341301
rS342446: MFC r341301
rS342338: MFC r341301
rS341301: sfxge(4): prevent access to the NIC config before probe
Summary

NIC config is initialized during NIC probe.

Submitted by: Mark Spender <mspender at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arybchik created this revision.Nov 21 2018, 11:55 AM
Harbormaster completed remote builds in B21121: Diff 50862.Nov 21 2018, 11:55 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:07 AM
Closed by commit rS341301: sfxge(4): prevent access to the NIC config before probe (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 30 2018, 7:07 AM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sfxge/
common/
1 line

Diff 51396

View Options

head/sys/dev/sfxge/common/efx_nic.c

.\" .\"
.Dd September 28, 2023 .Dd December 14, 2023
.Dt IPFW 8 .Dt IPFW 8
.Os .Os
.Sh NAME .Sh NAME
.Nm ipfw , dnctl .Nm ipfw , dnctl
.Nd User interface for firewall, traffic shaper, packet scheduler, .Nd User interface for firewall, traffic shaper, packet scheduler,
in-kernel NAT. in-kernel NAT.
.Sh SYNOPSIS .Sh SYNOPSIS
.Ss FIREWALL CONFIGURATION .Ss FIREWALL CONFIGURATION
▲ Show 20 Lines • Show All 3,023 Lines • ▼ Show 20 Lines
is normally reported to the caller routine in the kernel, in the is normally reported to the caller routine in the kernel, in the
same way as it happens when a device queue fills up. same way as it happens when a device queue fills up.
Setting this Setting this
option reports the packet as successfully delivered, which can be option reports the packet as successfully delivered, which can be
needed for some experimental setups where you want to simulate needed for some experimental setups where you want to simulate
loss or congestion at a remote router. loss or congestion at a remote router.
.Pp .Pp
.It Cm plr Ar packet-loss-rate .It Cm plr Ar packet-loss-rate
.It Cm plr Ar K,p,H,r
Packet loss rate. Packet loss rate.
Argument Argument
.Ar packet-loss-rate .Ar packet-loss-rate
is a floating-point number between 0 and 1, with 0 meaning no is a floating-point number between 0 and 1, with 0 meaning no
loss, 1 meaning 100% loss. loss, 1 meaning 100% loss.
The loss rate is internally represented on 31 bits. .Pp
When invoked with four arguments, the simple Gilbert-Elliott
channel model with two states (Good and Bad) is used.
.Bd -literal -offset indent
r
.----------------.
v |
.------------. .------------.
| G | | B |
| drop (K) | | drop (H) |
'------------' '------------'
| ^
'----------------'
p
.Ed
This has the associated probabilities
.Po Ar K
and
.Ar H Pc
for the loss probability. This is different from the literature,
where this model is described with probabilities of successful
transmission k and h. However, converting from literature is
easy:
.Pp
K = 1 - k ; H = 1 - h
.Pp
This is to retain consistency within the interface and allow the
quick re-use of loss probability when giving only a single argument.
In addition the state change probabilities
.Po Ar p
and
.Ar r Pc
are given.
All of the above probabilities are internally represented on 31 bits.
.Pp .Pp
.It Cm queue Brq Ar slots | size Ns Cm Kbytes .It Cm queue Brq Ar slots | size Ns Cm Kbytes
pauamma_gundo.comUnsubmitted
Done
Inline Actions

Worth being explicit that these arguments are comma-separated and mention their internal representation if relevant?

pauamma_gundo.com: Worth being explicit that these arguments are comma-separated and mention their internal…
rscheffAuthorUnsubmitted
Done
Inline Actions

Ideally, I wanted to have the parameters in loss probabilities; the literature of the gilbert-elliott model give these (k, h) as transmission probabilities - the inverse of what the simple PLR loss probability is;
Adjusted the code accordingly.
Alternatively, I could call these parameters K and H, with K = (1-k) and H = (1-h), keep the code more streamlined and the probabilities would align nicely with the simple PLR loss model...

Any opinions?

rscheff: Ideally, I wanted to have the parameters in loss probabilities; the literature of the gilbert…
pauamma_gundo.comUnsubmitted
Not Done
Inline Actions

I have no basis for an informed opinion on that point myself.

pauamma_gundo.com: I have no basis for an informed opinion on that point myself.
Queue size, in Queue size, in
.Ar slots .Ar slots
or or
.Cm KBytes . .Cm KBytes .
Default value is 50 slots, which Default value is 50 slots, which
is the typical queue size for Ethernet devices. is the typical queue size for Ethernet devices.
Note that for slow speed links you should keep the queue Note that for slow speed links you should keep the queue
size short or your traffic might be affected by a significant size short or your traffic might be affected by a significant
queueing delay. queueing delay.
pauamma_gundo.comUnsubmitted
Done
Inline Actions
.Po Ar change-to-B
and
- .Ar change-to-A Pc
+ .Ar change-to-G Pc
.
.Pp
.It Cm queue Brq Ar slots | size Ns Cm Kbytes

Or explain what A is.

pauamma_gundo.com: Or explain what A is.
E.g., 50 max-sized Ethernet packets (1500 bytes) mean 600Kbit E.g., 50 max-sized Ethernet packets (1500 bytes) mean 600Kbit
or 20s of queue on a 30Kbit/s pipe. or 20s of queue on a 30Kbit/s pipe.
Even worse effects can result if you get packets from an Even worse effects can result if you get packets from an
interface with a much larger MTU, e.g.\& the loopback interface interface with a much larger MTU, e.g.\& the loopback interface
with its 16KB packets. with its 16KB packets.
The The
.Xr sysctl 8 .Xr sysctl 8
variables variables
▲ Show 20 Lines • Show All 1,890 Lines • Show Last 20 Lines