ubldr: Fix booting PowerPC kernels
AbandonedPublic
Actions

Authored by jhibbits on Nov 28 2018, 2:09 AM.

Details

Reviewers

imp
nwhitehorn

Group Reviewers

PowerPC

Summary

Book-E powerpc kernels expect the device tree to be the first argument.
Match the powerpc/ofw ofw_exec function for powerpc. Also, since powerpc gates
passing the device tree on the 'usefdt' environment variable, force-set this
like for loader.kboot.

Test Plan

Test booted on an AmigaOne A1222

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21233
Build 20576: arc lint + arc unit

Event Timeline

jhibbits created this revision.Nov 28 2018, 2:09 AM

Harbormaster completed remote builds in B21233: Diff 51240.Nov 28 2018, 2:09 AM

mizhka added a subscriber: mizhka.Nov 28 2018, 5:31 AM

mizhka added inline comments.

stand/uboot/lib/elf_freebsd.c
94–95	I wonder what is magic constant?

jhibbits marked an inline comment as done.Nov 28 2018, 12:43 PM

jhibbits added inline comments.

stand/uboot/lib/elf_freebsd.c
94–95	Nathan put this magic constant in for PowerPC booting, to denote booting with the new loader, about a year ago, with the goal of distinguishing r6 as having a real metadata pointer instead of potentially garbage. Right now everything beyond dtbp is not used, but it will be in the future, as I bring booke booting up to parity with AIM.

No need for this anymore. Only needed the "usefdt" change, the rest was fixed in the kernel.

Revision Contents
Changeset List

Path

Size

stand/

uboot/

common/

main.c

3 lines

lib/

elf_freebsd.c

9 lines

Diff 51240

View Options

stand/uboot/common/main.c