Fix routing sysctl leaks.
ClosedPublic
Actions

Authored by markj on Nov 25 2018, 10:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 21, 12:52 PM

	Unknown Object (File)
	Mon, Apr 20, 6:22 AM

	Unknown Object (File)
	Wed, Apr 15, 9:49 AM

	Unknown Object (File)
	Sun, Apr 5, 7:10 AM

	Unknown Object (File)
	Fri, Apr 3, 5:55 AM

	Unknown Object (File)
	Tue, Mar 31, 12:25 PM

	Unknown Object (File)
	Tue, Mar 31, 5:10 AM

	Unknown Object (File)
	Tue, Mar 24, 3:29 AM

View All Files

Subscribers

imp

Details

Reviewers

Commits

rS340968: Plug routing sysctl leaks.

Summary

Some of the structures exported by sysctl_rtsock() contain padding
fields. A few of these were explicitly zeroed, but some were not. For
now, fix the problem by identifying the remaining pad fields and
clearing them.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21201
Build 20552: arc lint + arc unit

Event Timeline

markj created this revision.Nov 25 2018, 10:28 PM

Herald added a subscriber: ae. · View Herald TranscriptNov 25 2018, 10:28 PM

markj added a reviewer: ae.Nov 25 2018, 10:29 PM

Harbormaster completed remote builds in B21201: Diff 51094.Nov 25 2018, 10:31 PM

LGTM.

This revision is now accepted and ready to land.Nov 26 2018, 8:45 AM

Closed by commit rS340968: Plug routing sysctl leaks. (authored by markj). · Explain WhyNov 26 2018, 1:42 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 26 2018, 1:42 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

if.h

4 lines

route.h

1 line

rtsock.c

16 lines

Diff 51094

View Options

sys/net/if.h

View Options

sys/net/route.h

View Options

Fix routing sysctl leaks.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51094

sys/net/if.h

sys/net/route.h

sys/net/rtsock.c

Fix routing sysctl leaks.
ClosedPublic
Actions

Revision Contents
Changeset List