regulator_fixed: Do not disable fixed regulator at probe
ClosedPublic
Actions

Authored by manu on Nov 13 2018, 6:09 PM.

Details

Reviewers

Commits

rS350593: MFC r340987, r340989, r341254, r341269, r341333
rS340989: regulator_fixed: Do not disable fixed regulator at probe

Summary

If the regulator is unused it will be disabled by the regulator_shutdown sysinit.

Test Plan

Tested on pinebook where the backlight is controlled by a fixed-regulator.
The regulator doesn't have a regulator-boot-on param (I'm gonna upstream this) and so we disable it at probe.
We later enable it but this cause the screen to go black.
Linux doesn't disable regulator at boot (at least for fixed-regulator) so better match this to have the same UX.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

manu created this revision.Nov 13 2018, 6:09 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 13 2018, 6:09 PM

mmel added inline comments.Nov 15 2018, 6:19 AM

sys/dev/extres/regulator/regulator_fixed.c
161	This test doesn't works for regulators with active low enable. Imho, right (and more readable) way is something like: if (sc->param->boot_on \|\| sc->param->always_on) { rv = GPIO_PIN_SET(pin->dev, pin->pin, sc->param->enable_active_high); then, enable variable can be deleted completely.